Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UriTemplate.expand should support Iterable<?> for list parameters #118

Closed
wonderfly opened this issue Jan 9, 2015 · 3 comments

Comments

@wonderfly
Copy link
Contributor

commented Jan 9, 2015

From rmis...@google.com on May 21, 2012 07:17:29

Reported by willem.salembier, May 19 (42 hours ago)
Version of google-api-java-client: 1.9.0-beta
Java environment: Java 6

Freebase Text API is bugged. The Get object requires to be initialized with a List, but the buildHttpRequestUrl() method uses UriTemplate.expand which expects the id parameter to be passed as an Iterator and not an Iterable.

Get get = freebase.text().get(Arrays.asList("en", "avenue_q")); How would you expect it to be fixed? com.google.api.services.freebase.Freebase.Text.Get.getId() should return an Iterator or UriTemplate.expand should support Iterable for list parameters.

Original issue: http://code.google.com/p/google-http-java-client/issues/detail?id=118

@wonderfly

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2015

From rmis...@google.com on May 21, 2012 07:24:58

http://codereview.appspot.com/6208085/

Status: Started

@wonderfly

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2015

From rmis...@google.com on May 21, 2012 09:29:29

Labels: Component-HTTP

@wonderfly

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2015

From rmis...@google.com on May 22, 2012 13:30:09

Status: Fixed

@wonderfly wonderfly closed this Jan 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.