Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpHeader.parse fails on AppEngine for combined Set-Cookie headers #187

Closed
wonderfly opened this issue Jan 9, 2015 · 4 comments

Comments

@wonderfly
Copy link
Contributor

commented Jan 9, 2015

From dles...@gmail.com on January 05, 2013 04:25:17

Version of google-http-java-client: 1.12.0-beta
Java environment: AppEngine 1.7.4

Problem:
For certain web-sites, parsing a returned Set-Cookie HTTP header via java.net.HttpCookie#parse fails with java.lang.IllegalArgumentException ("Illegal cookie attribute")

Fix:
AppEngine recently introduced the long-awaited fix for the combined HTTP headers issue ( https://code.google.com/p/googleappengine/issues/detail?id=3379 )

To take advantage of the fix, replace "fetchResponse.getHeaders()" with "fetchResponse.getHeadersUncombined()" in UrlFetchResponse.java.

Original issue: http://code.google.com/p/google-http-java-client/issues/detail?id=187

@wonderfly

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2015

From yan...@google.com on January 24, 2013 06:10:57

Great news, thanks!

Status: Accepted
Owner: yan...@google.com
Cc: ngmic...@google.com
Labels: -Priority-Medium Priority-High Milestone-Version1.14.0

@wonderfly

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2015

From yan...@google.com on February 04, 2013 20:48:32

Labels: -Milestone-Version1.14.0 Milestone-Version1.15.0

@wonderfly

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2015

From yan...@google.com on April 15, 2013 14:52:01

Confirmed that getHeadersUncombined works: https://codereview.appspot.com/8778043/

Status: Started
Labels: -Type-Defect Type-Enhancement

@wonderfly

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2015

From yan...@google.com on April 18, 2013 07:33:28

Status: Fixed
Labels: Component-Google-AppEngine

@wonderfly wonderfly closed this Jan 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.