Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpResponse uses contains where it needs equals #842

Closed
elharo opened this issue Oct 14, 2019 · 0 comments · Fixed by #843
Closed

HttpResponse uses contains where it needs equals #842

elharo opened this issue Oct 14, 2019 · 0 comments · Fixed by #843
Assignees
Labels
good first issue help wanted priority: p2 semver: patch type: bug

Comments

@elharo
Copy link
Collaborator

@elharo elharo commented Oct 14, 2019

        if (!returnRawInputStream
             && contentEncoding != null	              && contentEncoding != null
             && contentEncoding.contains("gzip")) {

"contains" is incorrect. This should be equals or perhaps equalsIgnoreCase with a trim, or something like that. However it shouldn't fire on foogzipbar.

@elharo elharo added good first issue help wanted priority: p2 semver: patch type: bug labels Oct 14, 2019
egsavage added a commit to egsavage/google-http-java-client that referenced this issue Oct 14, 2019
egsavage added a commit to egsavage/google-http-java-client that referenced this issue Oct 19, 2019
egsavage added a commit to egsavage/google-http-java-client that referenced this issue Oct 20, 2019
egsavage added a commit to egsavage/google-http-java-client that referenced this issue Oct 27, 2019
egsavage added a commit to egsavage/google-http-java-client that referenced this issue Oct 27, 2019
egsavage added a commit to egsavage/google-http-java-client that referenced this issue Oct 29, 2019
chingor13 pushed a commit that referenced this issue Oct 29, 2019
* Issue #842 - HttpResponse GZip content encoding equality change

* Issue #842 - Added unit test, PR updates

* Issue #842 - Adjusted spacing, dropped ignoreCase on comparison

* Issue #842 - Enforce locale on encoding comparison, add unit tests

* Issue #842 - Removed final, fixed spelling

* Issue #842 - test updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted priority: p2 semver: patch type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants