Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calling getCurrentToken() twice in #982

ghost opened this issue Feb 21, 2020 · 0 comments · Fixed by #983

calling getCurrentToken() twice in #982

ghost opened this issue Feb 21, 2020 · 0 comments · Fixed by #983
type: cleanup


Copy link

@ghost ghost commented Feb 21, 2020

In in parseValue(Field, Type, ArrayList, Object, CustomizeJsonParser, boolean) at about line 720 local member JsonToken token is declared and assigned with call to getCurrentToken(). Two lines below the switch() calls getCurrentToken() again instead of use just declared and assigned token local member. Should be refactored so the switch uses the just declared and assigned member.

@yoshi-automation yoshi-automation added the triage me label Feb 21, 2020
@ghost ghost mentioned this issue Feb 23, 2020
@codyoss codyoss added type: cleanup and removed triage me labels Feb 24, 2020
codyoss pushed a commit that referenced this issue Feb 24, 2020
fix for #982

changed switch parameter in parseValue from calling getCurrentToken() again to just declared and assigned local member "token" two lines above
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 27, 2020
🤖 I have created a release \*beep\* \*boop\* 
## [1.35.0]( (2020-04-27)

### Features

* add logic for verifying ES256 JsonWebSignatures ([#1033]( ([bb4227f](

### Bug Fixes

* add linkage monitor plugin ([#1000]( ([027c227](
* Correctly handling chunked response streams with gzip ([#990]( ([1ba2197](, closes [#367](
* FileDataStoreFactory will throw IOException for any permissions errors ([#1012]( ([fd33073](
* include request method and URL into HttpResponseException message ([#1002]( ([15111a1](
* incorrect check for Windows OS in FileDataStoreFactory ([#927]( ([8b4eabe](
* reuse reference instead of calling getter twice ([#983]( ([1f66222](, closes [#982](
* **android:** set minimum API level to 19 a.k.a. 4.4 Kit Kat ([#1016]( ([b9a8023](, closes [#1015](

### Documentation

* android 4.4 or later is required ([#1008]( ([bcc41dd](
* libraries-bom 4.0.1 ([#976]( ([fc21dc4](
* libraries-bom 4.1.1 ([#984]( ([635c813](
* libraries-bom 5.2.0 ([#1032]( ([ca34202](
* require Android 4.4 ([#1007]( ([f9d2bb0](

### Dependencies

* httpclient 4.5.12 ([#991]( ([79bc1c7](
* update to Guava 29 ([#1024]( ([ca9520f](

This PR was generated with [Release Please](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
type: cleanup
None yet

Successfully merging a pull request may close this issue.

2 participants