Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: require Android 4.4 #1007

Merged
merged 1 commit into from Mar 20, 2020
Merged

docs: require Android 4.4 #1007

merged 1 commit into from Mar 20, 2020

Conversation

elharo
Copy link
Collaborator

@elharo elharo commented Mar 20, 2020

@chingor13 @BenWhitehead We now require API 19 or higher which means Android 4.4 or later.

@chingor13 @BenWhitehead We now require API 19 or higher which means Android 4.4 or later.
@elharo elharo added priority: p2 type: docs semver: patch labels Mar 20, 2020
@elharo elharo requested a review from chingor13 Mar 20, 2020
@elharo elharo requested a review from as a code owner Mar 20, 2020
@googlebot googlebot added the cla: yes label Mar 20, 2020
@chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Mar 20, 2020

Alternatively, we could provide the old implementation that was incompatible with windows in the google-http-client-android extensions artifact. This is only update we've taken that bumped the Android requirement.

@elharo
Copy link
Collaborator Author

@elharo elharo commented Mar 20, 2020

I'm not sure I follow your comment. Perhaps file a separate issue for that?

Meanwhile, the released version of this library does require Android 4.4 or later and the docs should reflect that.

@chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Mar 20, 2020

Only one class requires Android 4.4 (FileDatastoreFactory). If it's not a compile time issue, we can provide an alternative implementation (the original one that does not work on windows) in the google-http-client-android extensions artifact. If it is a compile time issue, we can protect with reflection.

@elharo elharo merged commit f9d2bb0 into master Mar 20, 2020
9 checks passed
@elharo elharo deleted the elharo-patch-1 branch Mar 20, 2020
@elharo
Copy link
Collaborator Author

@elharo elharo commented Mar 20, 2020

GenericUrl also requires it. See #926

gzsombor added a commit to gzsombor/google-http-java-client that referenced this issue Apr 1, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 27, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.35.0](https://www.github.com/googleapis/google-http-java-client/compare/v1.34.2...v1.35.0) (2020-04-27)


### Features

* add logic for verifying ES256 JsonWebSignatures ([#1033](https://www.github.com/googleapis/google-http-java-client/issues/1033)) ([bb4227f](https://www.github.com/googleapis/google-http-java-client/commit/bb4227f9daec44fc2976fa9947e2ff5ee07ed21a))


### Bug Fixes

* add linkage monitor plugin ([#1000](https://www.github.com/googleapis/google-http-java-client/issues/1000)) ([027c227](https://www.github.com/googleapis/google-http-java-client/commit/027c227e558164f77be204152fb47023850b543f))
* Correctly handling chunked response streams with gzip ([#990](https://www.github.com/googleapis/google-http-java-client/issues/990)) ([1ba2197](https://www.github.com/googleapis/google-http-java-client/commit/1ba219743e65c89bc3fdb196acc5d2042e01f542)), closes [#367](https://www.github.com/googleapis/google-http-java-client/issues/367)
* FileDataStoreFactory will throw IOException for any permissions errors ([#1012](https://www.github.com/googleapis/google-http-java-client/issues/1012)) ([fd33073](https://www.github.com/googleapis/google-http-java-client/commit/fd33073da3674997897d7a9057d1d0e9d42d7cd4))
* include request method and URL into HttpResponseException message ([#1002](https://www.github.com/googleapis/google-http-java-client/issues/1002)) ([15111a1](https://www.github.com/googleapis/google-http-java-client/commit/15111a1001d6f72cb92cd2d76aaed6f1229bc14a))
* incorrect check for Windows OS in FileDataStoreFactory ([#927](https://www.github.com/googleapis/google-http-java-client/issues/927)) ([8b4eabe](https://www.github.com/googleapis/google-http-java-client/commit/8b4eabe985794fc64ad6a4a53f8f96201cf73fb8))
* reuse reference instead of calling getter twice ([#983](https://www.github.com/googleapis/google-http-java-client/issues/983)) ([1f66222](https://www.github.com/googleapis/google-http-java-client/commit/1f662224d7bee6e27e8d66975fda39feae0c9359)), closes [#982](https://www.github.com/googleapis/google-http-java-client/issues/982)
* **android:** set minimum API level to 19 a.k.a. 4.4 Kit Kat ([#1016](https://www.github.com/googleapis/google-http-java-client/issues/1016)) ([b9a8023](https://www.github.com/googleapis/google-http-java-client/commit/b9a80232c9c8b16a3c3277458835f72e346f6b2c)), closes [#1015](https://www.github.com/googleapis/google-http-java-client/issues/1015)


### Documentation

* android 4.4 or later is required ([#1008](https://www.github.com/googleapis/google-http-java-client/issues/1008)) ([bcc41dd](https://www.github.com/googleapis/google-http-java-client/commit/bcc41dd615af41ae6fb58287931cbf9c2144a075))
* libraries-bom 4.0.1 ([#976](https://www.github.com/googleapis/google-http-java-client/issues/976)) ([fc21dc4](https://www.github.com/googleapis/google-http-java-client/commit/fc21dc412566ef60d23f1f82db5caf3cfd5d447b))
* libraries-bom 4.1.1 ([#984](https://www.github.com/googleapis/google-http-java-client/issues/984)) ([635c813](https://www.github.com/googleapis/google-http-java-client/commit/635c81352ae383b3abfe6d7c141d987a6944b3e9))
* libraries-bom 5.2.0 ([#1032](https://www.github.com/googleapis/google-http-java-client/issues/1032)) ([ca34202](https://www.github.com/googleapis/google-http-java-client/commit/ca34202bfa077adb70313b6c4562c7a5d904e064))
* require Android 4.4 ([#1007](https://www.github.com/googleapis/google-http-java-client/issues/1007)) ([f9d2bb0](https://www.github.com/googleapis/google-http-java-client/commit/f9d2bb030398fe09e3c47b84ea468603355e08e9))


### Dependencies

* httpclient 4.5.12 ([#991](https://www.github.com/googleapis/google-http-java-client/issues/991)) ([79bc1c7](https://www.github.com/googleapis/google-http-java-client/commit/79bc1c76ebd48d396a080ef715b9f07cd056b7ef))
* update to Guava 29 ([#1024](https://www.github.com/googleapis/google-http-java-client/issues/1024)) ([ca9520f](https://www.github.com/googleapis/google-http-java-client/commit/ca9520f2da4babc5bbd28c828da1deb7dbdc87e5))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@SanoKriss
Copy link

@SanoKriss SanoKriss commented Apr 30, 2020

Only one class requires Android 4.4 (FileDatastoreFactory). If it's not a compile time issue, we can provide an alternative implementation (the original one that does not work on windows) in the google-http-client-android extensions artifact. If it is a compile time issue, we can protect with reflection.

Yes please, make a fork compatible with API 17 Android, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes priority: p2 semver: patch type: docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants