Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logic for verifying ES256 JsonWebSignatures #1033

merged 3 commits into from Apr 24, 2020


Copy link

@chingor13 chingor13 commented Apr 24, 2020

Adds logic for verifying signatures that use NIST P-256 (ES256). It is up to the caller to provide the correct public key for verification.

Note that the difference between the ES256 and RS256 verification process is that ES256 requires AS1 (DER) notation for the signature so we do a limited conversion here before providing the signature to the signing algorithm.

Logic will be added to google-auth-library for handling Google's well-known, published public keys.

@chingor13 chingor13 requested a review from as a code owner Apr 24, 2020
@googlebot googlebot added the cla: yes label Apr 24, 2020
Copy link

@elharo elharo left a comment

I'm not an expert on this stuff, but it looks OK to me.

elharo approved these changes Apr 24, 2020
@chingor13 chingor13 merged commit bb4227f into googleapis:master Apr 24, 2020
8 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 27, 2020
🤖 I have created a release \*beep\* \*boop\* 
## [1.35.0]( (2020-04-27)

### Features

* add logic for verifying ES256 JsonWebSignatures ([#1033]( ([bb4227f](

### Bug Fixes

* add linkage monitor plugin ([#1000]( ([027c227](
* Correctly handling chunked response streams with gzip ([#990]( ([1ba2197](, closes [#367](
* FileDataStoreFactory will throw IOException for any permissions errors ([#1012]( ([fd33073](
* include request method and URL into HttpResponseException message ([#1002]( ([15111a1](
* incorrect check for Windows OS in FileDataStoreFactory ([#927]( ([8b4eabe](
* reuse reference instead of calling getter twice ([#983]( ([1f66222](, closes [#982](
* **android:** set minimum API level to 19 a.k.a. 4.4 Kit Kat ([#1016]( ([b9a8023](, closes [#1015](

### Documentation

* android 4.4 or later is required ([#1008]( ([bcc41dd](
* libraries-bom 4.0.1 ([#976]( ([fc21dc4](
* libraries-bom 4.1.1 ([#984]( ([635c813](
* libraries-bom 5.2.0 ([#1032]( ([ca34202](
* require Android 4.4 ([#1007]( ([f9d2bb0](

### Dependencies

* httpclient 4.5.12 ([#991]( ([79bc1c7](
* update to Guava 29 ([#1024]( ([ca9520f](

This PR was generated with [Release Please](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
cla: yes
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants