Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Android 19 compatible FileDataStoreFactory implementation #1070

Merged
merged 10 commits into from Jun 30, 2020

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Jun 26, 2020

Fixes #906

  • Adds an Android compatible FileDataStoreFactory implementation (version prior to switching to NIO) in the google-http-client-android extensions artifact
  • Adds a note in the core FileDataStoreFactory to use the new version on Android API level < 26
  • Adds an animal-sniffer check for Android API level 19 (Ignores the NIO Files API usage).

@googlebot googlebot added the cla: yes label Jun 26, 2020
@chingor13 chingor13 changed the title Android API usage Android API compatibility Jun 26, 2020
@chingor13 chingor13 changed the title Android API compatibility fix: Android API compatibility Jun 26, 2020
chingor13 added 2 commits Jun 26, 2020
This is branched from the original implementation prior to switching to
NIO for Windows compatibility.
@chingor13 chingor13 changed the title fix: Android API compatibility feat: add Android compatible FileDataStoreFactory implementation Jun 26, 2020
@chingor13 chingor13 marked this pull request as ready for review Jun 26, 2020
@chingor13 chingor13 requested a review from as a code owner Jun 26, 2020
@chingor13 chingor13 changed the title feat: add Android compatible FileDataStoreFactory implementation feat: add Android 19 compatible FileDataStoreFactory implementation Jun 26, 2020
chingor13 added 2 commits Jun 29, 2020
File setReadable(), setWritable(), setExecutable() was added in API
level 9, so we should not need to protect android users from missing
methods as we support Android API 19+.
@chingor13 chingor13 requested a review from elharo Jun 29, 2020
elharo
elharo approved these changes Jun 30, 2020
@chingor13 chingor13 merged commit 1150acd into googleapis:master Jun 30, 2020
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants