Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: version manage error_prone_annotations to 2.5.1 #1268

Merged
merged 1 commit into from Feb 23, 2021

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Feb 18, 2021

Fixes the dependencies presubmits

@chingor13 chingor13 requested a review from as a code owner Feb 18, 2021
@google-cla google-cla bot added the cla: yes label Feb 18, 2021
@@ -126,6 +126,11 @@
<version>1.1.2</version>
<scope>test</scope>
</dependency>
<dependency>
Copy link
Collaborator

@elharo elharo Feb 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the root cause here? We shouldn't need this in this repo. The failures are weird as they seem flaky and perhaps dependent on java 8 vs 11. I haven't dug into this yet.

Copy link
Contributor

@arithmetic1728 arithmetic1728 Feb 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem is that the guava dependencies are using different versions of error_prone_annotations (two use 2.3.4 and another one uses 2.5.1), and this causes enforcer failure. This PR specifies the error_prone_annotations version in pom.xml so only version 2.5.1 will be used.

[WARNING] Rule 2: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for com.google.errorprone:error_prone_annotations:2.3.4 paths to dependency are:
+-com.google.http-client:google-http-client:1.38.2-SNAPSHOT
  +-com.google.guava:guava:30.1-android
    +-com.google.errorprone:error_prone_annotations:2.3.4
and
+-com.google.http-client:google-http-client:1.38.2-SNAPSHOT
  +-com.google.guava:guava-testlib:30.1-android
    +-com.google.errorprone:error_prone_annotations:2.3.4
and
+-com.google.http-client:google-http-client:1.38.2-SNAPSHOT
  +-com.google.truth:truth:1.1.2
    +-com.google.errorprone:error_prone_annotations:2.5.1
]

Copy link
Collaborator

@elharo elharo Feb 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent a cl to update Guava, though it will be some time before that releases.

What I don't understand is why this problem is flaky. Sometimes I see it. Sometimes I don't. It feels like it should be always or never.

Copy link
Collaborator

@elharo elharo left a comment

Can you merge in master? I think the jackson javadoc issue should be fixed now

elharo
elharo approved these changes Feb 20, 2021
@suztomo
Copy link
Member

@suztomo suztomo commented Feb 23, 2021

Once this is merged, I'll have these GitHub Actions checks as required checks.
#1273

@chingor13 chingor13 merged commit 6a95f6f into master Feb 23, 2021
19 of 21 checks passed
@chingor13 chingor13 deleted the update-error-prone branch Feb 23, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Feb 24, 2021
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.39.0](https://www.github.com/googleapis/google-http-java-client/compare/v1.38.1...v1.39.0) (2021-02-24)


### Features

* add http.status_code attribute to all Spans that have at least a low level http response ([#986](https://www.github.com/googleapis/google-http-java-client/issues/986)) ([fb02042](https://www.github.com/googleapis/google-http-java-client/commit/fb02042ac216379820950879cea45d06eec5278c))


### Bug Fixes

* deprecate obsolete utility methods ([#1231](https://www.github.com/googleapis/google-http-java-client/issues/1231)) ([8f95371](https://www.github.com/googleapis/google-http-java-client/commit/8f95371cf5681fbc67bd598d74089f38742a1177))
* fix buildRequest setUrl order ([#1255](https://www.github.com/googleapis/google-http-java-client/issues/1255)) ([97ffee1](https://www.github.com/googleapis/google-http-java-client/commit/97ffee1a68af6637dd5d53fcd70e2ce02c9c9604))
* refactor to use StandardCharsets ([#1243](https://www.github.com/googleapis/google-http-java-client/issues/1243)) ([03ec798](https://www.github.com/googleapis/google-http-java-client/commit/03ec798d7637ff454614415be7b324cd8dc7c77c))
* remove old broken link ([#1275](https://www.github.com/googleapis/google-http-java-client/issues/1275)) ([12f80e0](https://www.github.com/googleapis/google-http-java-client/commit/12f80e09e71a41b967db548ab93cab2e3f4e549c)), closes [#1278](https://www.github.com/googleapis/google-http-java-client/issues/1278)
* remove unused logger ([#1228](https://www.github.com/googleapis/google-http-java-client/issues/1228)) ([779d383](https://www.github.com/googleapis/google-http-java-client/commit/779d3832ffce741b7c4055a14855ce8755695fce))


### Documentation

* Jackson is unable to maintain stable Javadocs ([#1265](https://www.github.com/googleapis/google-http-java-client/issues/1265)) ([9e8fcff](https://www.github.com/googleapis/google-http-java-client/commit/9e8fcfffc6d92505528aff0a89c169bf3e812c41))


### Dependencies

* update dependency com.google.protobuf:protobuf-java to v3.15.1 ([#1270](https://www.github.com/googleapis/google-http-java-client/issues/1270)) ([213726a](https://www.github.com/googleapis/google-http-java-client/commit/213726a0b65f35fdc65713027833d22b553bbc20))
* update dependency com.google.protobuf:protobuf-java to v3.15.2 ([#1284](https://www.github.com/googleapis/google-http-java-client/issues/1284)) ([dfa06bc](https://www.github.com/googleapis/google-http-java-client/commit/dfa06bca432f644a7146e3987555f19c5d1be7c5))
* update OpenCensus to 0.28.0 for consistency with gRPC ([#1242](https://www.github.com/googleapis/google-http-java-client/issues/1242)) ([b810d53](https://www.github.com/googleapis/google-http-java-client/commit/b810d53c8f63380c1b4f398408cfb47c6ab134cc))
* version manage error_prone_annotations to 2.5.1 ([#1268](https://www.github.com/googleapis/google-http-java-client/issues/1268)) ([6a95f6f](https://www.github.com/googleapis/google-http-java-client/commit/6a95f6f2494a9dafd968d212b15c9b329416864f))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gcf-owl-bot bot added a commit that referenced this issue Nov 4, 2021
)

* chore(java): remove pin on Apache Maven 3.8.1 from github actions

[Ubuntu 20.04.3 LTS](https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md) has updated the maven version to 3.8.3 which resolves[ the issue](googleapis/synthtool#1202) maven 3.8.2 had with flatten-maven-plugin

* chore: fix tests
Source-Link: googleapis/synthtool@79d7936
Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:ed012741acaae5d03e011244585a1f0625a596d31568967d77772aa5a0a51d5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants