Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add AttemptCount to HttpResponseException #1505

Merged
merged 3 commits into from Nov 23, 2021

Conversation

TimurSadykov
Copy link
Member

@TimurSadykov TimurSadykov commented Nov 18, 2021

This adds number of requests attempted to httpRequestException. This makes sense to know how many attempts were made since HttpRequest supports automated retries. We want to use it to improve user experience of Auth library, that leverages HttpRequest retry functionality.

For more details on the feature: go/auth-correct-retry

@TimurSadykov TimurSadykov requested a review from as a code owner Nov 18, 2021
@google-cla google-cla bot added the cla: yes label Nov 18, 2021
/**
* Returns the attempt count
*
* @since 1.41
Copy link
Member Author

@TimurSadykov TimurSadykov Nov 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if i need to add this manually

lesv
lesv approved these changes Nov 19, 2021
@Neenu1995 Neenu1995 merged commit ea0f6c0 into googleapis:main Nov 23, 2021
14 checks passed
ejona86 added a commit to ejona86/grpc-java that referenced this issue Apr 27, 2022
This reverts commit 0963f31. This
causes dependency problems when importing into Google, as
google-auth-library-java needs to be upgraded and that requires an
upgrade to google-http-java-client to bring in
googleapis/google-http-java-client#1505 .
Reverting for now and will roll forward once those upgrades are
performed.
sergiitk pushed a commit to grpc/grpc-java that referenced this issue Apr 27, 2022
This reverts commit 0963f31. This
causes dependency problems when importing into Google, as
google-auth-library-java needs to be upgraded and that requires an
upgrade to google-http-java-client to bring in
googleapis/google-http-java-client#1505 .
Reverting for now and will roll forward once those upgrades are
performed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants