Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HttpResponse GZip content encoding equality change #843

Merged

Conversation

egsavage
Copy link
Contributor

@egsavage egsavage commented Oct 14, 2019

Fixes #842 by having HttpResponse compare (case insensitive) the content-encoding against "gzip" and "x-gzip" (HTTP 1.1).

@egsavage egsavage requested a review from as a code owner Oct 14, 2019
@googlebot googlebot added the cla: yes label Oct 14, 2019
Copy link
Collaborator

@elharo elharo left a comment

This needs a test case.

egsavage added 2 commits Oct 19, 2019
…p-content-encoding

# Conflicts:
#	google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java
@egsavage
Copy link
Contributor Author

@egsavage egsavage commented Oct 19, 2019

This needs a test case.

Please see the latest commit.

@chingor13 chingor13 changed the title Issue #842 - HttpResponse GZip content encoding equality change fix: HttpResponse GZip content encoding equality change Oct 22, 2019
Copy link
Collaborator

@elharo elharo left a comment

The values should be case insensitive. See https://tools.ietf.org/html/rfc7230#section-3.2.4

"All transfer-coding names are case-insensitive". transfer-coding name is the name of the encoding such as gzip, not the name of HTTP header field.

@elharo elharo added the kokoro:force-run label Oct 28, 2019
@kokoro-team kokoro-team removed kokoro:force-run labels Oct 28, 2019
elharo
elharo approved these changes Oct 29, 2019
@elharo elharo added the kokoro:force-run label Oct 29, 2019
@kokoro-team kokoro-team removed the kokoro:force-run label Oct 29, 2019
@chingor13 chingor13 merged commit 9c73e1d into googleapis:master Oct 29, 2019
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants