Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfix: HttpResponse GZip content encoding equality change #843
+66
−12
Conversation
...e-http-client/src/main/java/com/google/api/client/http/HttpResponse.java
Show resolved
Hide resolved
...e-http-client/src/main/java/com/google/api/client/http/HttpResponse.java
Outdated
Show resolved
Hide resolved
...e-http-client/src/main/java/com/google/api/client/http/HttpResponse.java
Outdated
Show resolved
Hide resolved
|
This needs a test case. |
This comment has been minimized.
This comment has been minimized.
Please see the latest commit. |
...e-http-client/src/main/java/com/google/api/client/http/HttpResponse.java
Outdated
Show resolved
Hide resolved
...tp-client/src/test/java/com/google/api/client/http/HttpResponseTest.java
Outdated
Show resolved
Hide resolved
...e-http-client/src/main/java/com/google/api/client/http/HttpResponse.java
Outdated
Show resolved
Hide resolved
chingor13
changed the title
|
The values should be case insensitive. See https://tools.ietf.org/html/rfc7230#section-3.2.4 "All transfer-coding names are case-insensitive". transfer-coding name is the name of the encoding such as gzip, not the name of HTTP header field. |
...e-http-client/src/main/java/com/google/api/client/http/HttpResponse.java
Outdated
Show resolved
Hide resolved
...tp-client/src/test/java/com/google/api/client/http/HttpResponseTest.java
Show resolved
Hide resolved
...tp-client/src/test/java/com/google/api/client/http/HttpResponseTest.java
Show resolved
Hide resolved
...tp-client/src/test/java/com/google/api/client/http/HttpResponseTest.java
Show resolved
Hide resolved
...tp-client/src/test/java/com/google/api/client/http/HttpResponseTest.java
Outdated
Show resolved
Hide resolved
...tp-client/src/test/java/com/google/api/client/http/HttpResponseTest.java
Outdated
Show resolved
Hide resolved
chingor13
merged commit 9c73e1d
into
googleapis:master
8 checks passed
8 checks passed
cla/google
All necessary CLAs are signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
egsavage commentedOct 14, 2019
Fixes #842 by having HttpResponse compare (case insensitive) the content-encoding against "gzip" and "x-gzip" (HTTP 1.1).