Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use platform default TCP buffer sizes #855

Merged
merged 3 commits into from Oct 24, 2019

Conversation

@elharo
Copy link
Collaborator

elharo commented Oct 23, 2019

This is my first and best guess at fixing #820.

@chingor13 @chanseokoh

@elharo elharo requested a review from googleapis/yoshi-java as a code owner Oct 23, 2019
@googlebot googlebot added the cla: yes label Oct 23, 2019
@elharo elharo changed the title Speed Use platform default TCP buffer sizes Oct 23, 2019
@chanseokoh

This comment has been minimized.

Copy link
Collaborator

chanseokoh commented Oct 24, 2019

Awesome! Before this PR, as in #820, it took more than 45 seconds.

start timing com.google.api.client.http.apache.v2...
elapsed (s): 48.7

After I built the branch and used 1.32.2-SNAPSHOT, it is now super fast. Thanks for fixing this!

start timing com.google.api.client.http.apache.v2...
elapsed (s): 2.4
start timing com.google.api.client.http.apache.v2...
elapsed (s): 1.7
@chingor13 chingor13 changed the title Use platform default TCP buffer sizes fix: use platform default TCP buffer sizes Oct 24, 2019
@chingor13 chingor13 merged commit 238f4c5 into master Oct 24, 2019
8 checks passed
8 checks passed
Kokoro - Test: Binary Compatibility Build successful
Details
Kokoro - Test: Dependencies Build successful
Details
Kokoro - Test: Java 11 Build successful
Details
Kokoro - Test: Java 7 Build successful
Details
Kokoro - Test: Java 8 Build successful
Details
Kokoro - Test: Linkage Monitor Build successful
Details
Kokoro - Test: Windows Java 8 Build successful
Details
cla/google All necessary CLAs are signed
@chingor13 chingor13 deleted the speed branch Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.