Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support chunked transfer encoding #910

Merged
merged 6 commits into from Dec 17, 2019

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Dec 10, 2019

Currently any time HttpRequest works with encoded data it encodes
the data twice. Once for the actual stream and once for checking
the length of the stream. Instead, when there is encoding just don't
set the content length. This will cause the underlying transports,
with a few tweaks, to use Transfer-Encoding: chunked.

Fixes #648

Currently any time HttpRequest works with encoded data it encodes
the data twice. Once for the actaul stream and once for checking
the length of the stream. Instead, when there is encoding just don't
set the content length. This will cause the underlying transports,
with a few tweaks, to use Transfer-Encoding: chunked.

Fixes googleapis#648
@googlebot googlebot added the cla: yes label Dec 10, 2019
@codyoss
Copy link
Member Author

@codyoss codyoss commented Dec 10, 2019

Sorry for some whitespace churn. I ran the formatter for my commit, and it looks there were a handful of other files that were not complying.

@codyoss codyoss marked this pull request as ready for review Dec 10, 2019
@codyoss codyoss requested a review from as a code owner Dec 10, 2019
@codyoss codyoss requested review from and removed request for Dec 10, 2019
Copy link
Collaborator

@chingor13 chingor13 left a comment

Can we separate the formatting changes from this PR?

@codyoss
Copy link
Member Author

@codyoss codyoss commented Dec 10, 2019

Sure thing.

Copy link
Collaborator

@elharo elharo left a comment

The number of formatting changes in this PR make it hard to see the important parts.

@codyoss codyoss requested review from chingor13 and elharo Dec 10, 2019
@codyoss
Copy link
Member Author

@codyoss codyoss commented Dec 10, 2019

That should be better, only formatted the files I changed. Sorry about that.

Copy link
Collaborator

@elharo elharo left a comment

It's still easier if reformatting is done in a separate PR, and I'd try to avoid global reformatting in IDEs. Rewrapping paragraphs is not very useful.

@codyoss codyoss merged commit b8d6abe into googleapis:master Dec 17, 2019
9 checks passed
@codyoss codyoss deleted the transfer-encoding branch Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants