fix: set mediaType to null if contentType cannot be parsed#911
Merged
chingor13 merged 2 commits intogoogleapis:masterfrom Dec 10, 2019
Merged
fix: set mediaType to null if contentType cannot be parsed#911chingor13 merged 2 commits intogoogleapis:masterfrom
chingor13 merged 2 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
google-http-client/src/test/java/com/google/api/client/http/HttpResponseTest.java
Show resolved
Hide resolved
Avoids users hitting a runtime exception when the contentType is invalid.
Contributor
Author
|
I force-pushed to resolve the conventionalcommits error, but I'm afraid things might be in a weird state now - let me know if I need to fix this. |
chingor13
changed the title
chingor13
changed the title
chingor13
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
BenWhitehead
approved these changes
Dec 10, 2019
chingor13
approved these changes
Dec 10, 2019
Contributor
|
Note that this is potentially a behavior breaking change in that previously you could get an |
elharo
reviewed
Dec 10, 2019
Contributor
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
There might be an argument for defaulting to application/octet-stream instead of null.
clundin25
pushed a commit
to clundin25/google-http-java-client
that referenced
this pull request
Aug 11, 2022
…ent-bom to v1.41.7 (googleapis#911) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.http-client:google-http-client-bom](https://togithub.com/googleapis/google-http-java-client) | `1.41.6` -> `1.41.7` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/google-http-java-client</summary> ### [`v1.41.7`](https://togithub.com/googleapis/google-http-java-client/blob/HEAD/CHANGELOG.md#​1417-httpsgithubcomgoogleapisgoogle-http-java-clientcomparev1416v1417-2022-04-11) [Compare Source](https://togithub.com/googleapis/google-http-java-client/compare/v1.41.6...v1.41.7) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-auth-library-java).
](https://renovatebot.com){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #905 by setting mediaType to null if the contentType is invalid.