Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: decode uri path components correctly #913

Merged
merged 3 commits into from Dec 17, 2019

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Dec 10, 2019

The old implementation was incorrectly treating '+' as a space. Now
the only things that get decoded in the path are uri escaped sequences.

Fixes #398

The old implementation was incorrecly treating '+' as a space. Now
the only things that get decoded in the path are uri escaped sequences.

Fixes googleapis#398
@googlebot googlebot added the cla: yes label Dec 10, 2019
@codyoss codyoss marked this pull request as ready for review Dec 10, 2019
@codyoss codyoss requested a review from as a code owner Dec 10, 2019
Copy link
Collaborator

@elharo elharo left a comment

I could swear this is reinventing something that exists in Guava, but perhaps that's only in the internal version.

@codyoss codyoss requested a review from chingor13 Dec 16, 2019
@chingor13 chingor13 merged commit 7d4a048 into googleapis:master Dec 17, 2019
9 checks passed
@dmitry-fa
Copy link
Contributor

@dmitry-fa dmitry-fa commented Jan 15, 2020

This change caused the problem with using space in object names in java cloud storage:

googleapis/java-storage#53
googleapis/java-storage#57
googleapis/java-storage#121

@athakor
Copy link

@athakor athakor commented Feb 11, 2020

@dmitry-fa correct, one more issue related to this changes.
googleapis/java-storage#121

@codyoss codyoss deleted the generic-url branch Feb 2, 2022
@mihalyr
Copy link

@mihalyr mihalyr commented Feb 2, 2022

Hi, in https://issuetracker.google.com/issues/217399871 we have noticed a problem with Google Sheets API when using google-http-client version 1.34.0 or older that includes this change. The problem is handling + signs in sheet titles that lead to API failures when trying to append cells to a sheet that contains + in the title. This was working well before this change.

It is a bit confusing as the error message we get shows that the problem is that the sheet title is passed in the URL and the plus gets replaced by a space, while the value range in the body remains unchanged and this mismatch results in API failures that prevent adding cells to such sheets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants