feat: decode uri path components correctly #913
Conversation
The old implementation was incorrecly treating '+' as a space. Now the only things that get decoded in the path are uri escaped sequences. Fixes googleapis#398
googlebot
added
the
cla: yes
google-http-client/src/main/java/com/google/api/client/http/GenericUrl.java
Show resolved
Hide resolved
google-http-client/src/main/java/com/google/api/client/util/escape/CharEscapers.java
Outdated
Show resolved
Hide resolved
google-http-client/src/main/java/com/google/api/client/util/escape/CharEscapers.java
Outdated
Show resolved
Hide resolved
I could swear this is reinventing something that exists in Guava, but perhaps that's only in the internal version.
|
This change caused the problem with using space in object names in java cloud storage: googleapis/java-storage#53 |
|
@dmitry-fa correct, one more issue related to this changes. |
|
Hi, in https://issuetracker.google.com/issues/217399871 we have noticed a problem with Google Sheets API when using It is a bit confusing as the error message we get shows that the problem is that the sheet title is passed in the URL and the plus gets replaced by a space, while the value range in the body remains unchanged and this mismatch results in API failures that prevent adding cells to such sheets. |
The old implementation was incorrectly treating '+' as a space. Now
the only things that get decoded in the path are uri escaped sequences.
Fixes #398