Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update HttpRequest#getVersion to use stable logic #919

Merged
merged 1 commit into from Dec 17, 2019

Conversation

BenWhitehead
Copy link
Contributor

@BenWhitehead BenWhitehead commented Dec 17, 2019

The original implementation of getVersion used the implementation
version of the package of the declaring class, however there is
differing behavior between Android and openjdk based jvms.

In order to be consistent across platforms we will now always resolve
the value from the google-http-client.properties file that is
generated during the build. This method should be stable as it based
on loading a classpath resource which has cross jvm support.

Fixes #892

The original implementation of `getVersion` used the implementation
version of the package of the declaring class, however there is
differing behavior between Android and openjdk based jvms.

In order to be consistent across platforms we will now always resolve
the value from the `google-http-client.properties` file that is
generated during the build. This method should be stable as it based
on loading a classpath resource which has cross jvm support.

Fixes googleapis#892
@BenWhitehead BenWhitehead requested review from chingor13 and elharo Dec 17, 2019
@BenWhitehead BenWhitehead requested a review from as a code owner Dec 17, 2019
@googlebot googlebot added the cla: yes label Dec 17, 2019
@chingor13 chingor13 merged commit 853ab4b into googleapis:master Dec 17, 2019
9 checks passed
@BenWhitehead BenWhitehead deleted the fix-892 branch Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants