Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SAFEPATHCHARS_URLENCODER includes + #955

Merged
merged 1 commit into from Jan 22, 2020
Merged

fix: SAFEPATHCHARS_URLENCODER includes + #955

merged 1 commit into from Jan 22, 2020

Conversation

elharo
Copy link
Collaborator

@elharo elharo commented Jan 22, 2020

@elharo elharo requested a review from as a code owner Jan 22, 2020
@googlebot googlebot added the cla: yes label Jan 22, 2020
@frankyn frankyn changed the title SAFEPATHCHARS_URLENCODER includes + fix: SAFEPATHCHARS_URLENCODER includes + Jan 22, 2020
Copy link
Member

@frankyn frankyn left a comment

Verified this fixes Storage issue -> googleapis/java-storage#57

@chingor13 chingor13 merged commit 9384459 into master Jan 22, 2020
8 of 9 checks passed
@chingor13 chingor13 deleted the elharo-patch-2 branch Jan 22, 2020
Copy link
Collaborator Author

@elharo elharo left a comment

Really? This fixed #57? That comes as a complete surprise to me. I thought this was a small no-op cleanup I'd get out of the way before looking for the real bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants