Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch to GSON per security team advice #586

Merged
merged 8 commits into from Jan 11, 2021
Merged

fix: switch to GSON per security team advice #586

merged 8 commits into from Jan 11, 2021

Conversation

@elharo
Copy link
Collaborator

@elharo elharo commented Dec 29, 2020

@silvolu

@elharo elharo requested review from chingor13 and Dec 29, 2020
@elharo elharo requested a review from as a code owner Dec 29, 2020
@google-cla google-cla bot added the cla: yes label Dec 29, 2020
@chingor13 chingor13 changed the title switch to GSON per security team advice fix: switch to GSON per security team advice Dec 30, 2020
@elharo
Copy link
Collaborator Author

@elharo elharo commented Dec 31, 2020

DataNucleus failing on Windows. I'm not sure if this is flaky or not, but we do need to get this out of our build:

C:\Users\runneradmin.m2\repository\javax\servlet\servlet-api\2.5\servlet-api-2.5.jar
Errors were encountered when loading the specified MetaData files and classes. See the nested exceptions for details
DataNucleus Enhancer completed with an error. Please review the enhancer log (at DEBUG level) for full details. Some classes may have been enhanced but some caused errors

Error: --------------------
Error: Standard error from the DataNucleus tool + org.datanucleus.enhancer.DataNucleusEnhancer :
Error: --------------------
Error: log4j:WARN No appenders could be found for logger (DataNucleus.General).
log4j:WARN Please initialize the log4j system properly.
Error reading the Meta-Data input "Content is not allowed in prolog.
org.xml.sax.SAXParseException; lineNumber: 1; columnNumber: 1; Content is not allowed in prolog.
at com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:203)

@generated-files-bot
Copy link

@generated-files-bot generated-files-bot bot commented Jan 5, 2021

Warning: This pull request is touching the following templated files:

  • samples/snippets/pom.xml

@elharo elharo merged commit 58a1828 into master Jan 11, 2021
19 of 20 checks passed
@elharo elharo deleted the gson2 branch Jan 11, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 9, 2021
🤖 I have created a release \*beep\* \*boop\*
---
### [1.31.5](https://www.github.com/googleapis/google-oauth-java-client/compare/v1.31.4...v1.31.5) (2021-04-09)


### Bug Fixes

* don't swallow exceptions in LocalServerReceiver ([#595](https://www.github.com/googleapis/google-oauth-java-client/issues/595)) ([f39faec](https://www.github.com/googleapis/google-oauth-java-client/commit/f39faec9980fa65602a216fbf34555b744139443))
* oauth1 signing for url encoded content ([#538](https://www.github.com/googleapis/google-oauth-java-client/issues/538)) ([d9507e4](https://www.github.com/googleapis/google-oauth-java-client/commit/d9507e4c367cc870b811e28e3b206ef4661c67d8))
* remove Jackson from assembly ([#605](https://www.github.com/googleapis/google-oauth-java-client/issues/605)) ([a482000](https://www.github.com/googleapis/google-oauth-java-client/commit/a482000eddf3c056f57492487c4a2f1e2f81feeb))
* switch to GSON per security team advice ([#586](https://www.github.com/googleapis/google-oauth-java-client/issues/586)) ([58a1828](https://www.github.com/googleapis/google-oauth-java-client/commit/58a1828e8e291c59494893b2632c294dffe98b23))


### Dependencies

* update appengine packages to v1.9.84 ([#577](https://www.github.com/googleapis/google-oauth-java-client/issues/577)) ([3fbd4d5](https://www.github.com/googleapis/google-oauth-java-client/commit/3fbd4d5205215447969adb7fa93a46f309eed4a5))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants