-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload initiation fails due to asserting wrong HTTP status code #124
Labels
api: storage
Issues related to the googleapis/google-resumable-media-python API.
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
lisandromc
added a commit
to blink-media-inc/google-resumable-media-python
that referenced
this issue
May 8, 2020
Do you have bandwidth to take a look at making this fix? |
Ah, thanks @lisandromc for sending a fix, I'll review. |
gcf-merge-on-green bot
pushed a commit
that referenced
this issue
Jul 23, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [0.7.0](https://www.github.com/googleapis/google-resumable-media-python/compare/v0.6.0...v0.7.0) (2020-07-23) ### Features * add configurable checksum support for uploads ([#139](https://www.github.com/googleapis/google-resumable-media-python/issues/139)) ([68264f8](https://www.github.com/googleapis/google-resumable-media-python/commit/68264f811473a5aa06102912ea8d454b6bb59307)) ### Bug Fixes * accept `201 Created` as valid upload response ([#141](https://www.github.com/googleapis/google-resumable-media-python/issues/141)) ([00d280e](https://www.github.com/googleapis/google-resumable-media-python/commit/00d280e116d69f7f8d8a4b970bb1176e338f9ce0)), closes [#125](https://www.github.com/googleapis/google-resumable-media-python/issues/125) [#124](https://www.github.com/googleapis/google-resumable-media-python/issues/124) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the googleapis/google-resumable-media-python API.
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Code in module _upload.py, line 453 of method
_process_initiate_response
reads:However, initiating an upload against https://storage.googleapis.com yields a 201 Created response, so it fails to comply.
Fixing this is as simple as adding http_client.CREATED to line 455:
The text was updated successfully, but these errors were encountered: