-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(resumable-media): add customizable timeouts to upload/download methods #116
Conversation
I've been facing The user should be able to specify timeout while using |
@busunkim96 Somehow this slipped out of the focus, and it might be a good time to revive it. Added you as a reviewer based on the GitHub's suggestion, but feel free to delegate to someone else if that makes more sense, thanks! @anantzoid Thanks for bringing this back to attention. As this PR only adds configurable timeouts to uploads, I can add the same for the download methods, too, provided that the original feature request is confirmed (I personally don't see any reason why it shouldn't be). |
LGTM'd, but adding @crwilcox since the storage folks are other primary users of this library |
I will update the PR with timeouts to the download methods as well. |
@crwilcox Friendly ping, can you take a look? Thanks! |
@busunkim96 @frankyn Thanks for the reviews! When would it be possible to release a new version of |
Hi @plamut, let's wait until next week when everyone is back. |
Sounds good, there's no rush. |
Fixes #45.
This PR adds configurable timeouts to
upload
objects.Motivation:
We would like to add timeouts to BigQuery methods that depend on the file upload functionality (using resumable media), so that requests do not get stuck indefinitely at the transport layer.
Currently there is a default timeout used (61, 60), but that might not suit all use cases, hence the need for optional explicit timeout parameters.