-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add configurable crc32c checksumming for downloads #135
Conversation
Received a design suggestion to move the argument to the class constructor for the download class; looking into refactoring that now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think it LGTM, added a few comments for changes.
@frankyn PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, pending approval @crwilcox as well.
Fixed merge conflict and addressed comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed a potential refactor, adding that in.
Thanks for the suggestion, I was able to remove some duplication of code between Download and RawDownload and tighten it up a bit in general. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one more question on crc32c support for google-crc32c and how users are being warned.
Thanks for the refactor, it looks much cleaner!
@frankyn fixed coverage issue; PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @andrewsg,
pending kokoro failure:
Formatting issue:
flake8 google/resumable_media tests
black --check google/resumable_media tests
would reformat /tmpfs/src/github/google-resumable-media-python/tests/unit/requests/test_download.py
Oh no! 💥 💔 💥
1 file would be reformatted, 24 files would be left unchanged.
No description provided.