-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow space between checksums in header #170
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
a71e199
to
de724e9
Compare
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
The current checksum logic only allowed checksum headers in the format "crc32c=hash1,md5=hash2", but GCP may actually return them with a space in-between as "crc32c=hash1, md5=hash2". Resolves googleapis#169
de724e9
to
181f228
Compare
Hi @mcsimps2 thank you for the contribution. Could I bother you to make a corresponding issue for this? |
@mcsimps2 Cool, I just missed it :) |
Tests are reporting failed for linting, which is not your pr. I can create a separate PR and clean that up. |
The current checksum logic only allowed checksum headers in the format
crc32c=hash1,md5=hash2
, but GCP may actually return them with a space in-between ascrc32c=hash1, md5=hash2
.This means that checksums are not being verified correctly for any header response like the latter.
If you want an actual example of a response from GCP that demonstrates this, here's one:
Resolves #169