Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move async_resumable_media to _async_resumable_media #178

Merged
merged 4 commits into from
Sep 29, 2020
Merged

fix: move async_resumable_media to _async_resumable_media #178

merged 4 commits into from
Sep 29, 2020

Conversation

crwilcox
Copy link
Collaborator

moves the async surface to internal while we allow early access. #177 tracks moving it back once we are satisfied with quality, and this is actively used by a client.

@crwilcox crwilcox requested a review from a team as a code owner September 29, 2020 19:16
@crwilcox crwilcox changed the base branch from master to async September 29, 2020 19:17
@google-cla
Copy link

google-cla bot commented Sep 29, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 29, 2020
@crwilcox crwilcox added the cla: yes This human has signed the Contributor License Agreement. label Sep 29, 2020
@google-cla google-cla bot removed the cla: no This human has *not* signed the Contributor License Agreement. label Sep 29, 2020
tritone
tritone reviewed Sep 29, 2020
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe we should have a README at the top level of the async package noting that this is internal-only, as well? Not sure what the convention is in the python libraries.

@crwilcox
Copy link
Collaborator Author

So, the naming (leading _) should be enough, but I can certainly add a blurb as a note. sure :)

@crwilcox crwilcox merged commit e5fd1cc into googleapis:async Sep 29, 2020
@crwilcox crwilcox mentioned this pull request Sep 29, 2020
Merged
crwilcox added a commit that referenced this pull request Oct 5, 2020
@crwilcox @tritone
@tseaver @anibadde
feat: add _async_resumable_media experimental support (#179)
03c11ba 
Merge long-lived async branch

* refactor: use named consts for session Python versions

* chore(deps): pin 'google-crc32c < 0.2dev' (#160)

* feat: async changes to resumable upload/download (#153)

* chore(deps): use google-auth >= 1.22.0, 2.0dev which includes google.auth.default_async, aiohttp_requests (#176)

* fix: move `async_resumable_media` to `_async_resumable_media` (#178)

Co-authored-by: Chris Cotter <cjcotter@google.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
Co-authored-by: Tres Seaver <tseaver@palladion.com>
Co-authored-by: Anirudh Baddepudi <43104821+anibadde@users.noreply.github.com>
Co-authored-by: Anirudh Baddepuddi <anibadde@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crwilcox @tritone