-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: drop Python 2.7 support #229
Conversation
Release-As: 2.0.0b1 Closes #228.
Via: $ for f in $(git grep -l 'u"' google/ tests/ tests_async/); do > echo $f > sed -i -e 's/\<u"/"/g' $f > done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, but the major thing is the incorrect import. And maybe changes in test image files need to be reverted. Otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The six
pin sneaked back into constraints-3.6.txt
after merging the latest master
. When that is removed, I think we are good to go.
Edit: Ugh, and that urllib_parse
import again for some reason... (ah, it's actually still there, it was not fixed in all files)
I have nothing more to add, thanks for this cleanup! |
Marked as |
six
.u"
prefixes for text strings.Release-As: 2.0.0b1
Closes #228.