fix: add REQUEST_TIMEOUT 408 as retryable code #270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
http.client.REQUEST_TIMEOUT
(408) to retryable codes.Per team discussion with the GCS FnD team, HTTP status code 408's Request Timeout can be handled with exponential backoff and is retryable. An uploadBrokenConnection will cause a 408. 408 is currently included in retryable codes in python-storage, and should also be included in the resumable media package.
Fixes #271