Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Include ConnectionError and urllib3 exception as retriable #282

Merged
merged 2 commits into from
Oct 20, 2021
Merged

fix: Include ConnectionError and urllib3 exception as retriable #282

merged 2 commits into from
Oct 20, 2021

Conversation

andrewsg
Copy link
Contributor

No description provided.

@andrewsg andrewsg requested review from a team as code owners October 11, 2021 23:50
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/google-resumable-media-python API. label Oct 11, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2021
tseaver
tseaver reviewed Oct 12, 2021
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than the changes I suggested inline, perhaps it makes more sense to move wait_and_retry and the associated helpers down into the requests sub-package?

google/resumable_media/_helpers.py Outdated Show resolved Hide resolved
tests/unit/test__helpers.py Outdated Show resolved Hide resolved
@andrewsg
Copy link
Contributor Author

@tseaver I decided I agree with you on the architecture question; I don't remember what I was thinking when I put it in _helpers originally, but I've refactored retries to be in _request_helpers instead. I think that will resolve your feedback. PTAL

@tseaver tseaver merged commit d33465f into main Oct 20, 2021
@tseaver tseaver deleted the connectionreseterror branch October 20, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/google-resumable-media-python API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewsg @tseaver