From 1821985de2cfa4d05590abd0bdf4fef2fde22480 Mon Sep 17 00:00:00 2001 From: Google APIs Date: Wed, 30 Mar 2022 00:40:10 -0700 Subject: [PATCH] fix!: Updated resource patterns to comply with https://google.aip.dev/123#annotating-resource-types PiperOrigin-RevId: 438230444 --- google/cloud/certificatemanager/v1/BUILD.bazel | 8 ++++---- .../cloud/certificatemanager/v1/certificate_manager.proto | 8 +++++--- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/google/cloud/certificatemanager/v1/BUILD.bazel b/google/cloud/certificatemanager/v1/BUILD.bazel index 1d65edbc3510e..5b743392594b7 100644 --- a/google/cloud/certificatemanager/v1/BUILD.bazel +++ b/google/cloud/certificatemanager/v1/BUILD.bazel @@ -168,9 +168,9 @@ py_gapic_library( srcs = [":certificatemanager_proto"], grpc_service_config = "certificatemanager_grpc_service_config.json", opt_args = [ - "warehouse-package-name=google-cloud-certificate-manager", - "python-gapic-namespace=google.cloud", "python-gapic-name=certificate_manager", + "python-gapic-namespace=google.cloud", + "warehouse-package-name=google-cloud-certificate-manager", ], ) @@ -279,10 +279,10 @@ ruby_cloud_gapic_library( name = "certificatemanager_ruby_gapic", srcs = [":certificatemanager_proto_with_info"], extra_protoc_parameters = [ - "ruby-cloud-gem-name=google-cloud-certificate_manager-v1", - "ruby-cloud-product-url=https://cloud.google.com/certificate-manager", "ruby-cloud-api-id=certificatemanager.googleapis.com", "ruby-cloud-api-shortname=certificatemanager", + "ruby-cloud-gem-name=google-cloud-certificate_manager-v1", + "ruby-cloud-product-url=https://cloud.google.com/certificate-manager", ], grpc_service_config = "certificatemanager_grpc_service_config.json", ruby_cloud_description = "Certificate Manager lets you acquire and manage Transport Layer Security (TLS) (SSL) certificates for use with classic external HTTP(S) load balancers in Google Cloud.", diff --git a/google/cloud/certificatemanager/v1/certificate_manager.proto b/google/cloud/certificatemanager/v1/certificate_manager.proto index 720d4154625f1..be7df241c17ca 100644 --- a/google/cloud/certificatemanager/v1/certificate_manager.proto +++ b/google/cloud/certificatemanager/v1/certificate_manager.proto @@ -33,11 +33,11 @@ option php_namespace = "Google\\Cloud\\CertificateManager\\V1"; option ruby_package = "Google::Cloud::CertificateManager::V1"; option (google.api.resource_definition) = { type: "compute.googleapis.com/TargetHttpsProxies" - pattern: "projects/{project}/locations/{location}/targetHttpsProxies/{targetHttpsProxy}" + pattern: "projects/{project}/locations/{location}/targetHttpsProxies/{target_https_proxy}" }; option (google.api.resource_definition) = { type: "compute.googleapis.com/TargetSslProxies" - pattern: "projects/{project}/locations/{location}/targetSslProxies/{targetSslProxy}" + pattern: "projects/{project}/locations/{location}/targetSslProxies/{target_ssl_proxy}" }; // API Overview @@ -877,7 +877,9 @@ message Certificate { } // Output only. The list of Subject Alternative Names of dnsName type defined in the - // certificate (see RFC 5280 4.2.1.6) + // certificate (see RFC 5280 4.2.1.6). + // Managed certificates that haven't been provisioned yet have this field + // populated with a value of the managed.domains field. repeated string san_dnsnames = 6 [(google.api.field_behavior) = OUTPUT_ONLY]; // Output only. The PEM-encoded certificate chain.