Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the resource annotations for GetRepositoryRequest #171

Merged
merged 2 commits into from Oct 21, 2021

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Oct 14, 2021

  • Regenerate this pull request now.

BREAKING CHANGE: This will be a breaking change for languages that generate client libraries using resource annotations to provide overloads accepting resource names. Where previously such languages would have generated (in-pseudocode) GetRepository(LocationName) they will now (correctly) generate GetRepository(RepositoryName). Code using the older methods will be broken by this change, but would never have worked anyway.

PiperOrigin-RevId: 403028264

Source-Link: googleapis/googleapis@9bac62d

Source-Link: googleapis/googleapis-gen@4f54454
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGY1NDQ1NGI2NDliY2VkZWExNGJiMDE5NTVhNjU4NTBjZTkwNmQ5YiJ9

@gcf-owl-bot gcf-owl-bot bot requested a review from as a code owner Oct 14, 2021
@google-cla google-cla bot added the cla: yes label Oct 14, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run owlbot:run labels Oct 14, 2021
@product-auto-label product-auto-label bot added the api: artifactregistry label Oct 14, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 14, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run label Oct 14, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 14, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 14, 2021
@gcf-owl-bot
Copy link
Contributor Author

@gcf-owl-bot gcf-owl-bot bot commented Oct 19, 2021

Owl bot is regenerating pull request 171...
Build name: N2Q4OWVlOWYtYmU0OS00YzI2LWE0NGYtNTQyZDBjMDJjOWFk

@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-b56d7468-06dc-4964-8822-208eaa4252ef branch from bdede1e to 7452df5 Compare Oct 19, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run owlbot:run labels Oct 19, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 19, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run label Oct 19, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 19, 2021
@Neenu1995 Neenu1995 changed the title fix!: Fix the resource annotations for GetRepositoryRequest fix: Fix the resource annotations for GetRepositoryRequest Oct 21, 2021
@gcf-owl-bot
Copy link
Contributor Author

@gcf-owl-bot gcf-owl-bot bot commented Oct 21, 2021

Owl bot is regenerating pull request 171...
Build name: ZTVhY2FkMTMtMDc5My00YmZiLWIzZTUtMjU0M2U4ZjNkMDQ1

@Neenu1995 Neenu1995 added automerge kokoro:force-run labels Oct 21, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 21, 2021
BREAKING CHANGE: This will be a breaking change for languages that generate client libraries using resource annotations to provide overloads accepting resource names. Where previously such languages would have generated (in-pseudocode) GetRepository(LocationName) they will now (correctly) generate GetRepository(RepositoryName). Code using the older methods will be broken by this change, but would never have worked anyway.

PiperOrigin-RevId: 403028264

Source-Link: googleapis/googleapis@9bac62d

Source-Link: https://github.com/googleapis/googleapis-gen/commit/4f54454b649bcedea14bb01955a65850ce906d9b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGY1NDQ1NGI2NDliY2VkZWExNGJiMDE5NTVhNjU4NTBjZTkwNmQ5YiJ9
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-b56d7468-06dc-4964-8822-208eaa4252ef branch from 9a5ac1c to cc25412 Compare Oct 21, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run owlbot:run labels Oct 21, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 21, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 21, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run owlbot:run labels Oct 21, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 21, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 21, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit dd2adb5 into main Oct 21, 2021
16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot-b56d7468-06dc-4964-8822-208eaa4252ef branch Oct 21, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Oct 21, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Jan 7, 2022
🤖 I have created a release \*beep\* \*boop\*
---
## [0.5.0](https://www.github.com/googleapis/java-artifact-registry/compare/v0.4.3...v0.5.0) (2022-01-07)


###  BREAKING CHANGES

* This will be a breaking change for languages that generate client libraries using resource annotations to provide overloads accepting resource names. Where previously such languages would have generated (in-pseudocode) GetRepository(LocationName) they will now (correctly) generate GetRepository(RepositoryName). Code using the older methods will be broken by this change, but would never have worked anyway.

### Features

* Artifact Registry v1 public protos ([#159](https://www.github.com/googleapis/java-artifact-registry/issues/159)) ([3764ef6](https://www.github.com/googleapis/java-artifact-registry/commit/3764ef67c52af1692e2b66a7100c203d74c75c54))


### Bug Fixes

* **artifactregistry:** fix resource pattern ID segment name ([#193](https://www.github.com/googleapis/java-artifact-registry/issues/193)) ([a3edf3d](https://www.github.com/googleapis/java-artifact-registry/commit/a3edf3dc0f21c2075febf18a1ca8d6eea399b1f5))
* Fix the resource annotations for GetRepositoryRequest ([#171](https://www.github.com/googleapis/java-artifact-registry/issues/171)) ([dd2adb5](https://www.github.com/googleapis/java-artifact-registry/commit/dd2adb5df54f44734077b99aa9bb859f9bff8a51))
* **java:** add -ntp flag to native image testing command ([#1299](https://www.github.com/googleapis/java-artifact-registry/issues/1299)) ([#192](https://www.github.com/googleapis/java-artifact-registry/issues/192)) ([4d263cd](https://www.github.com/googleapis/java-artifact-registry/commit/4d263cd96b8c26e23f6b0d4223799f0e360710e1))
* **java:** java 17 dependency arguments ([#1266](https://www.github.com/googleapis/java-artifact-registry/issues/1266)) ([#177](https://www.github.com/googleapis/java-artifact-registry/issues/177)) ([0fa73db](https://www.github.com/googleapis/java-artifact-registry/commit/0fa73db98462b1564a6d9796202f22864034e132))
* **java:** run Maven in plain console-friendly mode ([#1301](https://www.github.com/googleapis/java-artifact-registry/issues/1301)) ([#196](https://www.github.com/googleapis/java-artifact-registry/issues/196)) ([a876c65](https://www.github.com/googleapis/java-artifact-registry/commit/a876c654640de5a140af549c74772f67a20ca221))


### Documentation

* fix docstring formatting ([#175](https://www.github.com/googleapis/java-artifact-registry/issues/175)) ([e97c22c](https://www.github.com/googleapis/java-artifact-registry/commit/e97c22cce17721c53e5173fc153f4e6b199038f9))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.4.0 ([#174](https://www.github.com/googleapis/java-artifact-registry/issues/174)) ([7991c2a](https://www.github.com/googleapis/java-artifact-registry/commit/7991c2a2708b81cd8e33a21ec7e4419053f05fee))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.0 ([#185](https://www.github.com/googleapis/java-artifact-registry/issues/185)) ([a19ed68](https://www.github.com/googleapis/java-artifact-registry/commit/a19ed68328854ee26465815ae3f3f740b24c4597))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.1 ([#190](https://www.github.com/googleapis/java-artifact-registry/issues/190)) ([67de42f](https://www.github.com/googleapis/java-artifact-registry/commit/67de42f028f9e405ea1eeb18e840e3c721506ca0))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.6.0 ([#198](https://www.github.com/googleapis/java-artifact-registry/issues/198)) ([0f68c71](https://www.github.com/googleapis/java-artifact-registry/commit/0f68c719b81ed21e2001b253aa8743652a62bc8c))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: artifactregistry cla: yes owl-bot-copy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants