Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate v1beta1 client endpoint is turned down #493

Merged
merged 2 commits into from Dec 21, 2020

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Dec 21, 2020

Endpoint was turned down 2020-09-28

Fixes #481

@google-cla google-cla bot added the cla: yes label Dec 21, 2020
@product-auto-label product-auto-label bot added the api: cloudasset label Dec 21, 2020
@generated-files-bot
Copy link

@generated-files-bot generated-files-bot bot commented Dec 21, 2020

Warning: This pull request is touching the following templated files:

  • google-cloud-asset/src/main/java/com/google/cloud/asset/v1beta1/AssetServiceClient.java
  • google-cloud-asset/src/main/java/com/google/cloud/asset/v1beta1/AssetServiceSettings.java
  • google-cloud-asset/src/main/java/com/google/cloud/asset/v1beta1/package-info.java
  • google-cloud-asset/src/main/java/com/google/cloud/asset/v1beta1/stub/AssetServiceStub.java
  • google-cloud-asset/src/main/java/com/google/cloud/asset/v1beta1/stub/AssetServiceStubSettings.java
  • google-cloud-asset/src/main/java/com/google/cloud/asset/v1beta1/stub/GrpcAssetServiceCallableFactory.java
  • google-cloud-asset/src/main/java/com/google/cloud/asset/v1beta1/stub/GrpcAssetServiceStub.java
  • grpc-google-cloud-asset-v1beta1/src/main/java/com/google/cloud/asset/v1beta1/AssetServiceGrpc.java

@codecov
Copy link

@codecov codecov bot commented Dec 21, 2020

Codecov Report

Merging #493 (6d31b13) into master (1509270) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #493   +/-   ##
=========================================
  Coverage     73.57%   73.57%           
  Complexity      275      275           
=========================================
  Files            36       36           
  Lines          2176     2176           
  Branches         11       11           
=========================================
  Hits           1601     1601           
  Misses          556      556           
  Partials         19       19           
Impacted Files Coverage Δ Complexity Δ
...google/cloud/asset/v1beta1/AssetServiceClient.java 40.00% <ø> (ø) 7.00 <0.00> (ø)
...ogle/cloud/asset/v1beta1/AssetServiceSettings.java 21.21% <ø> (ø) 2.00 <0.00> (ø)
...gle/cloud/asset/v1beta1/stub/AssetServiceStub.java 20.00% <ø> (ø) 1.00 <0.00> (ø)
...d/asset/v1beta1/stub/AssetServiceStubSettings.java 84.92% <ø> (ø) 12.00 <0.00> (ø)
.../v1beta1/stub/GrpcAssetServiceCallableFactory.java 50.00% <ø> (ø) 4.00 <0.00> (ø)
...cloud/asset/v1beta1/stub/GrpcAssetServiceStub.java 86.56% <ø> (ø) 10.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1509270...6d31b13. Read the comment docs.

@chingor13 chingor13 changed the title build: stop generating v1beta1 client - endpoint is turned down feat: deprecate v1beta1 client endpoint is turned down Dec 21, 2020
@chingor13 chingor13 marked this pull request as ready for review Dec 21, 2020
@chingor13 chingor13 requested a review from as a code owner Dec 21, 2020
@chingor13 chingor13 added the automerge label Dec 21, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 0d52720 into googleapis:master Dec 21, 2020
19 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudasset cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants