Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add v1p1beta1 client #68

Merged
merged 5 commits into from Jan 23, 2020
Merged

feat: add v1p1beta1 client #68

merged 5 commits into from Jan 23, 2020

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Jan 21, 2020

No description provided.

@googlebot googlebot added the cla: yes label Jan 21, 2020
@codecov
Copy link

@codecov codecov bot commented Jan 21, 2020

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #68   +/-   ##
=========================================
  Coverage     62.98%   62.98%           
  Complexity      167      167           
=========================================
  Files            24       24           
  Lines          1602     1602           
  Branches          8        8           
=========================================
  Hits           1009     1009           
  Misses          586      586           
  Partials          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65599f9...5bd4685. Read the comment docs.

@chingor13 chingor13 added the kokoro:force-run label Jan 21, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jan 21, 2020
@chingor13 chingor13 requested a review from Jan 22, 2020
@chingor13
Copy link
Collaborator Author

@chingor13 chingor13 commented Jan 22, 2020

Relies on the fix in: googleapis/synthtool#383

@@ -0,0 +1,230 @@
// Copyright 2019 Google LLC.
Copy link
Contributor

@kolea2 kolea2 Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2020 :)

Copy link
Collaborator Author

@chingor13 chingor13 Jan 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kolea2
kolea2 approved these changes Jan 23, 2020
@chingor13 chingor13 merged commit c85f8c7 into master Jan 23, 2020
12 of 13 checks passed
@chingor13 chingor13 deleted the v1p1beta1 branch Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants