Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: manage version bumping for v1p1beta1 artifacts #74

Merged
merged 1 commit into from Jan 30, 2020

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Jan 30, 2020

Our last release did not bump the v1p1beta1 artifact version because we didn't have that version in the versions.txt manifest

@chingor13 chingor13 requested review from kolea2 and Jan 30, 2020
@googlebot googlebot added the cla: yes label Jan 30, 2020
@codecov
Copy link

@codecov codecov bot commented Jan 30, 2020

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #74   +/-   ##
=========================================
  Coverage     62.98%   62.98%           
  Complexity      167      167           
=========================================
  Files            24       24           
  Lines          1602     1602           
  Branches          8        8           
=========================================
  Hits           1009     1009           
  Misses          586      586           
  Partials          7        7
Impacted Files Coverage Δ Complexity Δ
...google/cloud/asset/v1beta1/AssetServiceClient.java 0% <0%> (ø) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9c0a08...8bf8a26. Read the comment docs.

kolea2
kolea2 approved these changes Jan 30, 2020
@chingor13 chingor13 merged commit af83250 into master Jan 30, 2020
12 checks passed
@chingor13 chingor13 deleted the chingor13-patch-1 branch Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants