Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(samples): adds retry to TranslateCreateDatasetTest #513

Merged
merged 2 commits into from Mar 25, 2021

Conversation

telpirion
Copy link
Contributor

@telpirion telpirion commented Mar 23, 2021

This PR attempts to fix a flaky test for the TranslateCreateDataset sample.

Fixes #496 ☕️

@generated-files-bot
Copy link

@generated-files-bot generated-files-bot bot commented Mar 23, 2021

Warning: This pull request is touching the following templated files:

  • samples/install-without-bom/pom.xml
  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@product-auto-label product-auto-label bot added the api: automl label Mar 23, 2021
@google-cla google-cla bot added the cla: yes label Mar 23, 2021
@product-auto-label product-auto-label bot added the samples label Mar 23, 2021
@codecov
Copy link

@codecov codecov bot commented Mar 23, 2021

Codecov Report

Merging #513 (fbaf63d) into master (0c3abad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #513   +/-   ##
=========================================
  Coverage     80.38%   80.38%           
  Complexity      465      465           
=========================================
  Files            24       24           
  Lines          3548     3548           
  Branches         37       37           
=========================================
  Hits           2852     2852           
  Misses          627      627           
  Partials         69       69           
Impacted Files Coverage Δ Complexity Δ
.../java/com/google/cloud/automl/v1/AutoMlClient.java 77.17% <0.00%> (ø) 98.00% <0.00%> (ø%)
.../com/google/cloud/automl/v1beta1/AutoMlClient.java 79.75% <0.00%> (ø) 127.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c3abad...fbaf63d. Read the comment docs.

@telpirion telpirion requested a review from munkhuushmgl Mar 23, 2021
@telpirion telpirion marked this pull request as ready for review Mar 23, 2021
@telpirion telpirion requested a review from Mar 23, 2021
@telpirion telpirion requested a review from as a code owner Mar 23, 2021
@telpirion telpirion requested a review from stephaniewang526 Mar 23, 2021
lesv
lesv approved these changes Mar 24, 2021
@telpirion telpirion merged commit 762dd2f into master Mar 25, 2021
19 checks passed
@telpirion telpirion deleted the translate-dataset-test-fix branch Mar 25, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 12, 2021
🤖 I have created a release \*beep\* \*boop\*
---
### [1.4.1](https://www.github.com/googleapis/java-automl/compare/v1.4.0...v1.4.1) (2021-04-12)


### Bug Fixes

* **samples:** adds retry to TranslateCreateDatasetTest ([#513](https://www.github.com/googleapis/java-automl/issues/513)) ([762dd2f](https://www.github.com/googleapis/java-automl/commit/762dd2f4dae77f93d59bd82dbfa4f4a896d71dfa))


### Dependencies

* update dependency com.google.cloud:google-cloud-bigquery to v1.127.12 ([#489](https://www.github.com/googleapis/java-automl/issues/489)) ([0f4a58f](https://www.github.com/googleapis/java-automl/commit/0f4a58f5f56d647a2fc0c1ea4db3c82810f6e789))
* update dependency com.google.cloud:google-cloud-bigquery to v1.128.0 ([#527](https://www.github.com/googleapis/java-automl/issues/527)) ([e0e75bf](https://www.github.com/googleapis/java-automl/commit/e0e75bf6d757c3976cb7c195dc1de2b193ffa35d))
* update dependency com.google.cloud:google-cloud-core to v1.94.4 ([#515](https://www.github.com/googleapis/java-automl/issues/515)) ([d731204](https://www.github.com/googleapis/java-automl/commit/d7312043918b0df2f28c2da8ebb38fb18fc2ddf5))
* update dependency com.google.cloud:google-cloud-core to v1.94.6 ([#521](https://www.github.com/googleapis/java-automl/issues/521)) ([db46110](https://www.github.com/googleapis/java-automl/commit/db46110e94d5ab1bcc96b94d415dcc5a4a72ad5e))
* update dependency com.google.cloud:google-cloud-core to v1.94.7 ([#530](https://www.github.com/googleapis/java-automl/issues/530)) ([701c4a6](https://www.github.com/googleapis/java-automl/commit/701c4a654929daf73da195eacd950de89bc58329))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.21.0 ([#524](https://www.github.com/googleapis/java-automl/issues/524)) ([dc0e41c](https://www.github.com/googleapis/java-automl/commit/dc0e41cc04951b79d7a2b1b3f762704fb375818e))
* update dependency com.google.cloud:google-cloud-storage to v1.113.14 ([#504](https://www.github.com/googleapis/java-automl/issues/504)) ([a107e6b](https://www.github.com/googleapis/java-automl/commit/a107e6ba7cce751a31b7ff09a032c415b52c3110))
* update dependency net.sourceforge.argparse4j:argparse4j to v0.9.0 ([#522](https://www.github.com/googleapis/java-automl/issues/522)) ([8cf88ac](https://www.github.com/googleapis/java-automl/commit/8cf88ac086c6a95d6568e5df7c7ed9ec8cee7938))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: automl cla: yes samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants