From 19d92a144cd4d86fee6dd420e574c3a1a928642c Mon Sep 17 00:00:00 2001
From: Phong Chuong <147636638+PhongChuong@users.noreply.github.com>
Date: Mon, 22 Apr 2024 15:28:06 -0400
Subject: [PATCH] fix: Remove @InternalApi from TableResult (#3257)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* fix: Remove @InternalApi from TableResult

Since users depends on TableResult in testing, removing @InternalApi forces maintainers to change/roll out changes to TableResult more carefully in the future.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Remove clirr ignore difference entries for TableResult

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
---
 .../clirr-ignored-differences.xml             | 38 -------------------
 .../google/cloud/bigquery/TableResult.java    |  2 -
 2 files changed, 40 deletions(-)

diff --git a/google-cloud-bigquery/clirr-ignored-differences.xml b/google-cloud-bigquery/clirr-ignored-differences.xml
index abf827b48..9c69fd6a6 100644
--- a/google-cloud-bigquery/clirr-ignored-differences.xml
+++ b/google-cloud-bigquery/clirr-ignored-differences.xml
@@ -2,17 +2,6 @@
 <!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
 <differences>
   <!-- TODO: REMOVE AFTER RELEASE -->
-  <difference>
-    <differenceType>3005</differenceType>
-    <className>com/google/cloud/bigquery/TableResult*</className>
-    <justification>TableResult is an internal API and it should be fine to update</justification>
-  </difference>
-  <difference>
-    <differenceType>7002</differenceType>
-    <className>com/google/cloud/bigquery/TableResult*</className>
-    <method>*TableResult(*)</method>
-    <justification>TableResult is an internal API and it should be fine to update</justification>
-  </difference>
   <difference>
     <differenceType>7004</differenceType>
     <className>com/google/cloud/bigquery/spi/v2/BigQueryRpc</className>
@@ -25,19 +14,6 @@
     <method>com.google.api.services.bigquery.model.GetQueryResultsResponse getQueryResultsWithRowLimit(java.lang.String, java.lang.String, java.lang.String, java.lang.Integer)</method>
     <justification>getQueryResultsWithRowLimit is just used by ConnectionImpl at the moment so it should be fine to update the signature instead of writing an overloaded method</justification>
   </difference>
-  <difference>
-    <differenceType>7004</differenceType>
-    <className>com/google/cloud/bigquery/TableResult*</className>
-    <method>*TableResult(*)</method>
-    <justification>It should be fine to update TableResult constructors since it is used to return results to the user and users should not directly construct TableResult objects</justification>
-  </difference>
-  <difference>
-    <differenceType>7005</differenceType>
-    <className>com/google/cloud/bigquery/TableResult*</className>
-    <method>*TableResult(*)</method>
-    <to>*TableResult(*)</to>
-    <justification>It should be fine to update TableResult constructors since it is used to return results to the user and users should not directly construct TableResult objects</justification>
-  </difference>
   <difference>
     <differenceType>7013</differenceType>
     <className>com/google/cloud/bigquery/ExternalTableDefinition*</className>
@@ -58,16 +34,6 @@
     <className>com/google/cloud/bigquery/TableInfo*</className>
     <method>*ResourceTags(*)</method>
   </difference>
-  <difference>
-    <differenceType>7013</differenceType>
-    <className>com/google/cloud/bigquery/TableResult*</className>
-    <method>*getPageNoSchema(*)</method>
-  </difference>
-  <difference>
-    <differenceType>7013</differenceType>
-    <className>com/google/cloud/bigquery/TableResult*</className>
-    <method>*toBuilder(*)</method>
-  </difference>
   <difference>
     <differenceType>7012</differenceType>
     <className>com/google/cloud/bigquery/Connection</className>
@@ -163,8 +129,4 @@
     <className>com/google/cloud/bigquery/StandardTableDefinition*</className>
     <method>*BigLakeConfiguration(*)</method>
   </difference>
-  <difference>
-    <differenceType>8001</differenceType>
-    <className>com/google/cloud/bigquery/EmptyTableResult*</className>
-  </difference>
   </differences>
\ No newline at end of file
diff --git a/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/TableResult.java b/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/TableResult.java
index 203a91fab..1b4b0e101 100644
--- a/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/TableResult.java
+++ b/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/TableResult.java
@@ -16,7 +16,6 @@
 
 package com.google.cloud.bigquery;
 
-import com.google.api.core.InternalApi;
 import com.google.api.gax.paging.Page;
 import com.google.auto.value.AutoValue;
 import com.google.common.base.Function;
@@ -27,7 +26,6 @@
 import java.util.Objects;
 import javax.annotation.Nullable;
 
-@InternalApi
 @AutoValue
 public abstract class TableResult implements Page<FieldValueList>, Serializable {