Skip to content
Permalink
Browse files
feat: support for Table ACLs (#653)
* feat: bigquery table acls

* incremental updates

* syntax

* cleanup warnings

* add policy conversion tests

* add BigQueryImpl testing

* cleanup tests

* address mock issue

* plumb in testIamPermissions and impl test

* add integration test

* drop empty check

* allow more permissive policy conversions for (empty bindings)

* more null fun

* add clirr-ignored-differences.xml for new methods added to interfaces

Co-authored-by: stephwang <stephwang@google.com>
  • Loading branch information
shollyman and stephaniewang526 committed Aug 25, 2020
1 parent f08becc commit f0e67d8a63fdfe62bcd285c3bbb04cae79386229
@@ -0,0 +1,35 @@
<?xml version="1.0" encoding="UTF-8"?>
<!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
<differences>
<!--TODO: To be removed-->
<difference>
<differenceType>7012</differenceType>
<className>com/google/cloud/bigquery/BigQuery</className>
<method>com.google.cloud.Policy getIamPolicy(com.google.cloud.bigquery.TableId, com.google.cloud.bigquery.BigQuery$IAMOption[])</method>
</difference>
<difference>
<differenceType>7012</differenceType>
<className>com/google/cloud/bigquery/BigQuery</className>
<method>com.google.cloud.Policy setIamPolicy(com.google.cloud.bigquery.TableId, com.google.cloud.Policy, com.google.cloud.bigquery.BigQuery$IAMOption[])</method>
</difference>
<difference>
<differenceType>7012</differenceType>
<className>com/google/cloud/bigquery/BigQuery</className>
<method>java.util.List testIamPermissions(com.google.cloud.bigquery.TableId, java.util.List, com.google.cloud.bigquery.BigQuery$IAMOption[])</method>
</difference>
<difference>
<differenceType>7012</differenceType>
<className>com/google/cloud/bigquery/spi/v2/BigQueryRpc</className>
<method>com.google.api.services.bigquery.model.Policy getIamPolicy(java.lang.String, java.util.Map)</method>
</difference>
<difference>
<differenceType>7012</differenceType>
<className>com/google/cloud/bigquery/spi/v2/BigQueryRpc</className>
<method>com.google.api.services.bigquery.model.Policy setIamPolicy(java.lang.String, com.google.api.services.bigquery.model.Policy, java.util.Map)</method>
</difference>
<difference>
<differenceType>7012</differenceType>
<className>com/google/cloud/bigquery/spi/v2/BigQueryRpc</className>
<method>com.google.api.services.bigquery.model.TestIamPermissionsResponse testIamPermissions(java.lang.String, java.util.List, java.util.Map)</method>
</difference>
</differences>
@@ -393,6 +393,7 @@ Access toPb() {
*/
public static final class IamMember extends Entity {

private static final long serialVersionUID = 3562909264454016939L;
private final String iamMember;

/** Creates a iamMember entity given the iamMember. */

0 comments on commit f0e67d8

Please sign in to comment.