Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reservation usage in job statistics #1018

Merged
merged 1 commit into from Feb 5, 2021

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Dec 11, 2020

Fixes #1087

@pmakani pmakani requested a review from as a code owner Dec 11, 2020
@product-auto-label product-auto-label bot added the api: bigquery label Dec 11, 2020
@google-cla google-cla bot added the cla: yes label Dec 11, 2020
@codecov
Copy link

@codecov codecov bot commented Dec 11, 2020

Codecov Report

Merging #1018 (50c3e85) into master (93ea6fb) will decrease coverage by 0.05%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1018      +/-   ##
============================================
- Coverage     80.18%   80.12%   -0.06%     
  Complexity     1268     1268              
============================================
  Files            79       79              
  Lines          6576     6617      +41     
  Branches        760      765       +5     
============================================
+ Hits           5273     5302      +29     
- Misses          910      917       +7     
- Partials        393      398       +5     
Impacted Files Coverage Δ Complexity Δ
.../java/com/google/cloud/bigquery/JobStatistics.java 89.45% <71.42%> (-1.86%) 16.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93ea6fb...50c3e85. Read the comment docs.

@stephaniewang526 stephaniewang526 added the do not merge label Dec 11, 2020
@stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Dec 11, 2020

As discussed with @shollyman off-line, we will wait for a bug fix related to cost control. Otherwise, LGTM.

@stephaniewang526 stephaniewang526 removed the do not merge label Feb 5, 2021
@stephaniewang526 stephaniewang526 merged commit 49cbb0f into googleapis:master Feb 5, 2021
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants