Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): update querypagination sample #1209

Merged
merged 1 commit into from Mar 31, 2021

Conversation

ShyamShah11
Copy link
Contributor

@ShyamShah11 ShyamShah11 commented Mar 31, 2021

Based on feedback from a support case, I've made some changes to make this more clear and more accurate to what the comments indicate

Created #1207 to track this

Fixes #1207 ☕️

@ShyamShah11 ShyamShah11 requested a review from Mar 31, 2021
@product-auto-label product-auto-label bot added api: bigquery samples labels Mar 31, 2021
@google-cla google-cla bot added the cla: yes label Mar 31, 2021
@codecov
Copy link

@codecov codecov bot commented Mar 31, 2021

Codecov Report

Merging #1209 (305f4cc) into master (2918a5b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1209   +/-   ##
=========================================
  Coverage     80.17%   80.17%           
  Complexity     1270     1270           
=========================================
  Files            79       79           
  Lines          6629     6629           
  Branches        766      767    +1     
=========================================
  Hits           5315     5315           
  Misses          916      916           
  Partials        398      398           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2918a5b...305f4cc. Read the comment docs.

lesv
lesv approved these changes Mar 31, 2021
@lesv lesv added automerge and removed automerge labels Mar 31, 2021
@lesv lesv requested a review from stephaniewang526 Mar 31, 2021
@lesv lesv added kokoro:force-run automerge labels Mar 31, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 31, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 9b4f3ec into googleapis:master Mar 31, 2021
18 of 20 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Mar 31, 2021
@ShyamShah11 ShyamShah11 deleted the query-pagination branch Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery cla: yes samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants