Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add debug statement to StandardTableDefinition #128

Merged

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Jan 27, 2020

Debugs b/148288889

@googlebot googlebot added the cla: yes label Jan 27, 2020
@stephaniewang526 stephaniewang526 requested a review from tswast Jan 27, 2020
Copy link
Contributor

@tswast tswast left a comment

Please add unit tests with "invalid" time partitioning.

@codecov
Copy link

@codecov codecov bot commented Jan 27, 2020

Codecov Report

Merging #128 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #128      +/-   ##
============================================
+ Coverage     77.38%   77.43%   +0.05%     
  Complexity     1110     1110              
============================================
  Files            73       73              
  Lines          5916     5930      +14     
  Branches        645      645              
============================================
+ Hits           4578     4592      +14     
  Misses         1013     1013              
  Partials        325      325
Impacted Files Coverage Δ Complexity Δ
...google/cloud/bigquery/StandardTableDefinition.java 93.9% <100%> (+1.25%) 16 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a1480f...b1f0c8c. Read the comment docs.

@stephaniewang526 stephaniewang526 requested a review from tswast Jan 27, 2020
tswast
tswast approved these changes Jan 28, 2020
[WARNING] Used undeclared dependencies found:
[WARNING]    org.hamcrest:hamcrest-core:jar:1.3:test
@stephaniewang526 stephaniewang526 requested a review from tswast Jan 28, 2020
tswast
tswast approved these changes Jan 28, 2020
@stephaniewang526 stephaniewang526 requested review from tswast and pmakani Jan 28, 2020
tswast
tswast approved these changes Jan 28, 2020
@stephaniewang526 stephaniewang526 merged commit 660ccf2 into googleapis:master Jan 28, 2020
15 checks passed
@stephaniewang526 stephaniewang526 deleted the spotify-b-148288889 branch Jan 28, 2020
@stephaniewang526 stephaniewang526 changed the title chore: add debug statement to StandardTableDefinition feat: add debug statement to StandardTableDefinition Jan 28, 2020
chingor13 pushed a commit that referenced this issue Jan 28, 2020
* chore: add debug statement to StandardTableDefinition

* update to include cause

* remove changes to method headers

* update base on comment

* adding testcase

* adding testcases

* fix test dep build error

[WARNING] Used undeclared dependencies found:
[WARNING]    org.hamcrest:hamcrest-core:jar:1.3:test

* update to add more info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants