Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle specific exceptions #1370

Merged
merged 13 commits into from Jun 15, 2021
Merged

fix: handle specific exceptions #1370

merged 13 commits into from Jun 15, 2021

Conversation

prash-mi
Copy link
Contributor

@prash-mi prash-mi commented Jun 13, 2021

Added retry logic on java.net.ConnectException and java.net.UnknownHostException for BigQueryImpl.listDatasets() and BigQueryImpl.queryRpc() methods

Fixes # #1254 and googleapis/gax-java#1301 ☕️

@prash-mi prash-mi requested a review from as a code owner Jun 13, 2021
@prash-mi prash-mi requested a review from stephaniewang526 Jun 13, 2021
@product-auto-label product-auto-label bot added the api: bigquery label Jun 13, 2021
@google-cla google-cla bot added the cla: yes label Jun 13, 2021
@@ -0,0 +1,36 @@
/*
* Copyright 2015 Google LLC
Copy link
Member

@stephaniewang526 stephaniewang526 Jun 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copyright 2015 Google LLC
* Copyright 2021 Google LLC

Copy link
Contributor Author

@prash-mi prash-mi Jun 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Jun 14, 2021

Hi Prashant, please update the PR subject and initial commit to fix: handle specific exceptions -- we follow conventionalcommits standards.
Also, please run linter: mvn com.coveo:fmt-maven-plugin:format to clear the lint failure.

@prash-mi prash-mi changed the title Bug Fixes: fix: handle specific exceptions Jun 15, 2021
@prash-mi
Copy link
Contributor Author

@prash-mi prash-mi commented Jun 15, 2021

Hi Stephanie,

I have updated the subject and have fixed the linting error. Please let me know if you see any further issues.

Regards,
Prashant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants