Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug fix for get method of Bigquery Dataset #1379



Copy link

@prash-mi prash-mi commented Jun 18, 2021

Fixed Dataset.get(String tableId, TableOption... options) method's implementation to use the projectId associated with DatasetId, if one is present. Otherwise default to Bigquery's instance's projectId. Added test case.

Fixes #1369 ☕️

@prash-mi prash-mi requested a review from as a code owner Jun 18, 2021
@prash-mi prash-mi requested a review from loferris Jun 18, 2021
@product-auto-label product-auto-label bot added the api: bigquery label Jun 18, 2021
@google-cla google-cla bot added the cla: yes label Jun 18, 2021
@stephaniewang526 stephaniewang526 merged commit f034a99 into googleapis:master Jun 19, 2021
18 checks passed
@prash-mi prash-mi deleted the bigquery-getdataset-fix-1369 branch Jun 21, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 25, 2021
🤖 I have created a release \*beep\* \*boop\*
## [1.134.0]( (2021-06-25)

### Features

* add support for jobs.delete ([#1387]( ([95f1a6c](
* add support for parameterized type ([#1390]( ([b1fb57c](, closes [#1309](

### Bug Fixes

* bug fix for get method of Bigquery Dataset ([#1379]( ([f034a99](

### Dependencies

* update dependency to v2-rev20210529-1.31.5 ([#1380]( ([4a6906a](
* update dependency to v2-rev20210611-1.31.5 ([#1383]( ([b09f951](
* update dependency to v1.27.0 ([#1384]( ([6c4d886](

### Documentation

* **sample:** update UpdateTableExpiration sample ([#1389]( ([ac854c4](, closes [#1371](

This PR was generated with [Release Please]( See [documentation](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
api: bigquery cla: yes
None yet

Successfully merging this pull request may close these issues.

2 participants