Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for transactioninfo in query statistics #1497

Merged

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Aug 10, 2021

Fixes #1467

@stephaniewang526 stephaniewang526 requested a review from as a code owner Aug 10, 2021
@stephaniewang526 stephaniewang526 requested a review from shollyman Aug 10, 2021
@google-cla google-cla bot added the cla: yes label Aug 10, 2021
@product-auto-label product-auto-label bot added the api: bigquery label Aug 10, 2021
@@ -2219,6 +2220,27 @@ public void testDmlStatistics() throws InterruptedException {
assertEquals(2L, statistics.getDmlStats().getUpdatedRowCount().longValue());
}

@Test
public void testTransactionInfo() throws InterruptedException {
String tableName = TABLE_ID_FASTQUERY.getTable();
Copy link
Contributor

@shollyman shollyman Aug 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to worry about test ordering, or is this created in a setup?

Copy link
Member Author

@stephaniewang526 stephaniewang526 Aug 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this out. Yes, this is fine since the later test case will still update the table given the WHERE TRUE condition.

@stephaniewang526 stephaniewang526 added the automerge label Aug 10, 2021
@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Aug 11, 2021

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Aug 11, 2021
trigger github actions

remove breakline

lint
@stephaniewang526 stephaniewang526 added the automerge label Aug 11, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4c3b2de into googleapis:master Aug 11, 2021
15 of 17 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants