Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not throw NPE from BigQueryImpl.testIamPermissions #1596

Conversation

rculbertson
Copy link
Contributor

@rculbertson rculbertson commented Sep 20, 2021

Fix for issue where BigQueryImpl.testIamPermissions will throw a NullPointerException if the caller does not have any of the permissions being checked.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1595 ☕️

@rculbertson rculbertson requested a review from as a code owner Sep 20, 2021
@product-auto-label product-auto-label bot added the api: bigquery label Sep 20, 2021
@google-cla google-cla bot added the cla: yes label Sep 20, 2021
@rculbertson rculbertson changed the title Fix for BigQueryImpl.testIamPermissions NPE fix: do not throw NPE from BigQueryImpl.testIamPermissions Sep 20, 2021
Fix for issue where BigQueryImpl.testIamPermissions will throw a
NullPointerException if the caller does not have any of the permissions
being checked.
@rculbertson rculbertson force-pushed the rculbertson/test-iam-permissions-npe branch from a7d8df7 to e5e72be Compare Sep 20, 2021
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Sep 20, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run labels Sep 20, 2021
@stephaniewang526 stephaniewang526 added the automerge label Sep 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4251b19 into googleapis:master Sep 20, 2021
14 of 16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Sep 20, 2021
@rculbertson rculbertson deleted the rculbertson/test-iam-permissions-npe branch Sep 21, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants