Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add materialize view #174

Merged

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Feb 18, 2020

No description provided.

@googlebot googlebot added the cla: yes label Feb 18, 2020
@codecov
Copy link

@codecov codecov bot commented Feb 18, 2020

Codecov Report

Merging #174 into master will decrease coverage by 0.02%.
The diff coverage is 71.87%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #174      +/-   ##
============================================
- Coverage     77.36%   77.33%   -0.03%     
- Complexity     1116     1123       +7     
============================================
  Files            73       74       +1     
  Lines          5950     5982      +32     
  Branches        626      635       +9     
============================================
+ Hits           4603     4626      +23     
  Misses         1019     1019              
- Partials        328      337       +9
Impacted Files Coverage Δ Complexity Δ
...ava/com/google/cloud/bigquery/TableDefinition.java 87.09% <100%> (+0.88%) 8 <0> (+1) ⬆️
...gle/cloud/bigquery/MaterializedViewDefinition.java 70% <70%> (ø) 6 <6> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e568dc...2e7789c. Read the comment docs.

Copy link
Contributor

@shollyman shollyman left a comment

Still waiting on the backend team to confirm path forward regarding updates.

@stephaniewang526 stephaniewang526 added kokoro:force-run automerge labels Mar 18, 2020
@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Mar 18, 2020

Your PR was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. See required reviews for your repo here: https://github.com/googleapis/sloth/blob/master/required-checks.json

@pmakani pmakani force-pushed the materialize-view-definition branch from 29f154d to bade2c8 Compare Mar 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 19, 2020
@stephaniewang526 stephaniewang526 removed the automerge label Mar 19, 2020
@stephaniewang526 stephaniewang526 merged commit d33b645 into googleapis:master Mar 20, 2020
14 of 16 checks passed
@pmakani pmakani deleted the materialize-view-definition branch Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants