Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate BQ Java samples from java-docs-samples to client lib #22

Merged
merged 3 commits into from Dec 12, 2019

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Dec 11, 2019

Fixes b/146052864

@googlebot googlebot added the cla: yes label Dec 11, 2019
@codecov
Copy link

@codecov codecov bot commented Dec 11, 2019

Codecov Report

No coverage uploaded for pull request base (master@841d075). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #22   +/-   ##
=========================================
  Coverage          ?   77.29%           
  Complexity        ?     1107           
=========================================
  Files             ?       73           
  Lines             ?     5901           
  Branches          ?      635           
=========================================
  Hits              ?     4561           
  Misses            ?     1010           
  Partials          ?      330

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 841d075...61494ff. Read the comment docs.

Copy link
Contributor

@chingor13 chingor13 left a comment

We'll need to fix the dependencies test as well.

samples/pom.xml Show resolved Hide resolved
samples/pom.xml Show resolved Hide resolved
@stephaniewang526 stephaniewang526 requested a review from chingor13 Dec 11, 2019
@BenWhitehead
Copy link

@BenWhitehead BenWhitehead commented Dec 11, 2019

We also need to disable release for the sample module. @chingor13 How do we do that with the current setup of things.

Copy link
Contributor

@chingor13 chingor13 left a comment

I opened #23 to track figuring out the release config

@stephaniewang526 stephaniewang526 merged commit f0bdc4d into master Dec 12, 2019
13 checks passed
@stephaniewang526 stephaniewang526 deleted the feat-migrate-samples branch Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants