Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add struct query parameters #223

Merged
merged 6 commits into from Mar 20, 2020

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Mar 16, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #203

@googlebot googlebot added the cla: yes label Mar 16, 2020
@codecov
Copy link

@codecov codecov bot commented Mar 16, 2020

Codecov Report

Merging #223 into master will increase coverage by 0.23%.
The diff coverage is 95.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #223      +/-   ##
============================================
+ Coverage     77.36%   77.59%   +0.23%     
- Complexity     1116     1146      +30     
============================================
  Files            73       75       +2     
  Lines          5950     6074     +124     
  Branches        626      648      +22     
============================================
+ Hits           4603     4713     +110     
+ Misses         1019     1017       -2     
- Partials        328      344      +16
Impacted Files Coverage Δ Complexity Δ
...com/google/cloud/bigquery/QueryParameterValue.java 81.77% <95.83%> (+9.04%) 60 <3> (+14) ⬆️
...om/google/cloud/bigquery/LoadJobConfiguration.java 87.02% <0%> (-2.62%) 52% <0%> (ø)
...google/cloud/bigquery/HivePartitioningOptions.java 93.75% <0%> (ø) 9% <0%> (?)
...gle/cloud/bigquery/MaterializedViewDefinition.java 70% <0%> (ø) 6% <0%> (?)
...ava/com/google/cloud/bigquery/TableDefinition.java 87.09% <0%> (+0.88%) 8% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee02cc1...a0600cf. Read the comment docs.

@pmakani pmakani added the kokoro:force-run label Mar 17, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 17, 2020
@athakor athakor added the kokoro:force-run label Mar 17, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 17, 2020
@pmakani pmakani added the kokoro:force-run label Mar 17, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 17, 2020
@stephaniewang526 stephaniewang526 merged commit c1997dd into googleapis:master Mar 20, 2020
16 checks passed
@pmakani pmakani deleted the bigquery-203 branch Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants