Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extract model for extractjobconfiguration #227

Merged
merged 2 commits into from May 12, 2020

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Mar 17, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #202

@googlebot googlebot added the cla: yes label Mar 17, 2020
@codecov
Copy link

@codecov codecov bot commented Mar 17, 2020

Codecov Report

Merging #227 into master will increase coverage by 1.10%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #227      +/-   ##
============================================
+ Coverage     77.36%   78.46%   +1.10%     
- Complexity     1116     1287     +171     
============================================
  Files            73       77       +4     
  Lines          5950     6728     +778     
  Branches        626      804     +178     
============================================
+ Hits           4603     5279     +676     
- Misses         1019     1080      +61     
- Partials        328      369      +41     
Impacted Files Coverage Δ Complexity Δ
...google/cloud/bigquery/ExtractJobConfiguration.java 93.18% <88.88%> (-1.32%) 39.00 <12.00> (+12.00) ⬇️
...va/com/google/cloud/bigquery/TimePartitioning.java 100.00% <0.00%> (ø) 12.00% <0.00%> (+5.00%)
...gle/cloud/bigquery/MaterializedViewDefinition.java 70.00% <0.00%> (ø) 6.00% <0.00%> (?%)
...ain/java/com/google/cloud/bigquery/PolicyTags.java 100.00% <0.00%> (ø) 5.00% <0.00%> (?%)
.../com/google/cloud/bigquery/ConnectionProperty.java 91.89% <0.00%> (ø) 12.00% <0.00%> (?%)
...google/cloud/bigquery/HivePartitioningOptions.java 83.78% <0.00%> (ø) 11.00% <0.00%> (?%)
...google/cloud/bigquery/StandardTableDefinition.java 93.90% <0.00%> (+0.23%) 16.00% <0.00%> (ø%)
...src/main/java/com/google/cloud/bigquery/Field.java 83.22% <0.00%> (+0.61%) 44.00% <0.00%> (+19.00%)
...m/google/cloud/bigquery/QueryJobConfiguration.java 78.84% <0.00%> (+1.98%) 75.00% <0.00%> (+19.00%)
...ain/java/com/google/cloud/bigquery/FieldValue.java 85.00% <0.00%> (+2.85%) 38.00% <0.00%> (+14.00%)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f6529...82fad57. Read the comment docs.

@athakor athakor added the kokoro:force-run label Mar 18, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 18, 2020
@stephaniewang526 stephaniewang526 added automerge kokoro:force-run labels Mar 18, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 18, 2020
@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Mar 18, 2020

Your PR was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. See required reviews for your repo here: https://github.com/googleapis/sloth/blob/master/required-checks.json

Copy link
Contributor

@shollyman shollyman left a comment

Thanks!

@pmakani pmakani added the kokoro:force-run label May 12, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label May 12, 2020
@pmakani pmakani merged commit 9e8cd76 into googleapis:master May 12, 2020
16 checks passed
@pmakani pmakani deleted the extract-model branch May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants