Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose hivepartitioningoptions #233

Merged
merged 2 commits into from Mar 19, 2020

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Mar 19, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #202

@googlebot googlebot added the cla: yes label Mar 19, 2020
@codecov
Copy link

@codecov codecov bot commented Mar 19, 2020

Codecov Report

Merging #233 into master will decrease coverage by 0.00%.
The diff coverage is 77.27%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #233      +/-   ##
============================================
- Coverage     77.36%   77.35%   -0.01%     
- Complexity     1116     1125       +9     
============================================
  Files            73       74       +1     
  Lines          5950     5993      +43     
  Branches        626      630       +4     
============================================
+ Hits           4603     4636      +33     
- Misses         1019     1025       +6     
- Partials        328      332       +4     
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/bigquery/LoadJobConfiguration.java 87.02% <33.33%> (-2.62%) 52.00 <0.00> (ø)
...google/cloud/bigquery/HivePartitioningOptions.java 93.75% <93.75%> (ø) 9.00 <9.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f6529...250d26e. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 6213ea9 into googleapis:master Mar 19, 2020
14 of 16 checks passed
@pmakani pmakani deleted the hivepartitioningoptions branch Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants