Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support connection properties for job and query #320

Merged
merged 1 commit into from May 5, 2020

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented May 5, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #306

@googlebot googlebot added the cla: yes label May 5, 2020
@codecov
Copy link

@codecov codecov bot commented May 5, 2020

Codecov Report

Merging #320 into master will increase coverage by 0.13%.
The diff coverage is 94.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #320      +/-   ##
============================================
+ Coverage     77.56%   77.70%   +0.13%     
- Complexity     1158     1172      +14     
============================================
  Files            76       77       +1     
  Lines          6103     6153      +50     
  Branches        656      660       +4     
============================================
+ Hits           4734     4781      +47     
  Misses         1020     1020              
- Partials        349      352       +3     
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/bigquery/ConnectionProperty.java 91.89% <91.89%> (ø) 12.00 <12.00> (?)
...m/google/cloud/bigquery/QueryJobConfiguration.java 77.68% <100.00%> (+0.82%) 58.00 <1.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fccb0b4...febacc0. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit dcd3663 into googleapis:master May 5, 2020
16 checks passed
@pmakani pmakani deleted the bigquery-306 branch May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants