Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): Added UpdateTableDescription example. #360

Merged

Conversation

ejdarrow
Copy link
Contributor

@ejdarrow ejdarrow commented May 18, 2020

@ejdarrow ejdarrow requested a review from stephaniewang526 as a code owner May 18, 2020
@googlebot googlebot added the cla: yes label May 18, 2020
@codecov
Copy link

@codecov codecov bot commented May 18, 2020

Codecov Report

Merging #360 into master will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #360      +/-   ##
============================================
+ Coverage     77.70%   77.91%   +0.21%     
- Complexity     1172     1188      +16     
============================================
  Files            77       77              
  Lines          6153     6218      +65     
  Branches        660      691      +31     
============================================
+ Hits           4781     4845      +64     
- Misses         1020     1022       +2     
+ Partials        352      351       -1     
Impacted Files Coverage Δ Complexity Δ
...google/cloud/bigquery/ExtractJobConfiguration.java 93.18% <0.00%> (-1.32%) 39.00% <0.00%> (+12.00%) ⬇️
...e/cloud/bigquery/testing/RemoteBigQueryHelper.java 61.40% <0.00%> (-0.42%) 6.00% <0.00%> (ø%)
.../google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java 5.20% <0.00%> (-0.04%) 2.00% <0.00%> (ø%)
...ain/java/com/google/cloud/bigquery/Clustering.java 100.00% <0.00%> (ø) 5.00% <0.00%> (ø%)
...ain/java/com/google/cloud/bigquery/PolicyTags.java 100.00% <0.00%> (ø) 5.00% <0.00%> (ø%)
...java/com/google/cloud/bigquery/BigtableColumn.java 100.00% <0.00%> (ø) 5.00% <0.00%> (ø%)
...java/com/google/cloud/bigquery/TimelineSample.java 100.00% <0.00%> (ø) 5.00% <0.00%> (ø%)
...va/com/google/cloud/bigquery/TimePartitioning.java 100.00% <0.00%> (ø) 7.00% <0.00%> (ø%)
...om/google/cloud/bigquery/ModelTableDefinition.java 100.00% <0.00%> (ø) 4.00% <0.00%> (ø%)
...src/main/java/com/google/cloud/bigquery/Field.java 83.49% <0.00%> (+0.16%) 27.00% <0.00%> (ø%)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cb5ba3...614b924. Read the comment docs.

@stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented May 18, 2020

in the future, commit msg should be "docs(samples): added UpdateTableDescription.." so that we can pass conventionalcommit check.

@stephaniewang526 stephaniewang526 merged commit 96d2c87 into googleapis:master May 18, 2020
23 of 24 checks passed
@ejdarrow ejdarrow deleted the update-table-description branch May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants