Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use libraries-bom for samples #38

Merged
merged 1 commit into from Dec 17, 2019

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Dec 16, 2019

No description provided.

@stephaniewang526 stephaniewang526 requested a review from elharo Dec 16, 2019
@googlebot googlebot added the cla: yes label Dec 16, 2019
@stephaniewang526 stephaniewang526 requested a review from chingor13 Dec 16, 2019
@codecov
Copy link

@codecov codecov bot commented Dec 16, 2019

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #38   +/-   ##
=========================================
  Coverage     77.36%   77.36%           
  Complexity     1107     1107           
=========================================
  Files            73       73           
  Lines          5911     5911           
  Branches        644      645    +1     
=========================================
  Hits           4573     4573           
  Misses         1012     1012           
  Partials        326      326

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37022b0...3cfa581. Read the comment docs.

BenWhitehead
BenWhitehead previously requested changes Dec 17, 2019
samples/pom.xml Show resolved Hide resolved
elharo
elharo approved these changes Dec 17, 2019
@stephaniewang526 stephaniewang526 merged commit f519da2 into googleapis:master Dec 17, 2019
13 checks passed
@stephaniewang526 stephaniewang526 deleted the libraries-bom branch Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants