Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): Convert tightly coupled local variable involved options inside of method into method arguments #393

Conversation

irvifa
Copy link
Contributor

@irvifa irvifa commented May 28, 2020

As of the current version we can see that more options related to argument
are written inside of the test instead of included as arguments, so I think
as this is tightly coupled with argument, it will be better to pass it as well.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #394 ☕️

…s inside of method into method arguments

As of the current version we can see that more options related to argument
are written inside of the test instead of included as arguments, so I think
as this is tightly coupled with argument, it will be better to pass it as well.
@irvifa irvifa requested a review from stephaniewang526 as a code owner May 28, 2020
@googlebot googlebot added the cla: yes label May 28, 2020
@codecov
Copy link

@codecov codecov bot commented May 28, 2020

Codecov Report

Merging #393 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #393   +/-   ##
=========================================
  Coverage     77.88%   77.88%           
  Complexity     1184     1184           
=========================================
  Files            77       77           
  Lines          6218     6218           
  Branches        691      691           
=========================================
  Hits           4843     4843           
  Misses         1021     1021           
  Partials        354      354           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e21be2...4cc931d. Read the comment docs.

@irvifa irvifa changed the title docs(samples): Convert tightly coupled local variable involved option… docs(samples): Convert tightly coupled local variable involved options inside of method into method arguments May 28, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run label May 28, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label May 28, 2020
@stephaniewang526 stephaniewang526 added automerge kokoro:force-run labels May 28, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label May 28, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit a11f3cb into googleapis:master May 28, 2020
12 of 15 checks passed
@irvifa irvifa deleted the allow-argument-passing-in-examples branch May 28, 2020
@stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented May 28, 2020

@irvifa
Copy link
Contributor Author

@irvifa irvifa commented May 28, 2020

@stephaniewang526 is it specifically only for that test? Because I can see that the BQ table can’t be found when the test was run.

@stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented May 28, 2020

Yes it's specific to the test -- maybe we need to add UUID to tablename. Sometimes we run tests concurrently and it can cause issues. The same test did not fail in Java 8.

@irvifa irvifa mentioned this pull request May 28, 2020
4 tasks
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 1, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
### [1.116.1](https://www.github.com/googleapis/java-bigquery/compare/v1.116.0...v1.116.1) (2020-06-01)


### Dependencies

* remove google-cloud-core classiier=test since it is managed by … ([#396](https://www.github.com/googleapis/java-bigquery/issues/396)) ([bafd8ae](https://www.github.com/googleapis/java-bigquery/commit/bafd8ae780121ee968bca7b3eb68bb0f0a438124))
* restrict -annotation deps ([#402](https://www.github.com/googleapis/java-bigquery/issues/402)) ([db41581](https://www.github.com/googleapis/java-bigquery/commit/db4158186b99d0bed68fd70bef5918b1820e5dd1))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.6.0 ([#392](https://www.github.com/googleapis/java-bigquery/issues/392)) ([3f13ccb](https://www.github.com/googleapis/java-bigquery/commit/3f13ccbbf1ca8f179c48a69c8e456bdf45c43af5))
* update shared-deps and add back certain test deps ([#390](https://www.github.com/googleapis/java-bigquery/issues/390)) ([7e21be2](https://www.github.com/googleapis/java-bigquery/commit/7e21be2506cdaf065cd32e3aed403890929b93e7))


### Documentation

* **samples:** Convert tightly coupled local variable inside of method into method arguments ([#386](https://www.github.com/googleapis/java-bigquery/issues/386)) ([7c02cd3](https://www.github.com/googleapis/java-bigquery/commit/7c02cd3ca7238d24bb2914ae2262a3b2e2d4bda7)), closes [#387](https://www.github.com/googleapis/java-bigquery/issues/387)
* **samples:** Convert tightly coupled local variable involved options inside of method into method arguments ([#393](https://www.github.com/googleapis/java-bigquery/issues/393)) ([a11f3cb](https://www.github.com/googleapis/java-bigquery/commit/a11f3cb4733215a9c4a65936b05f9cc2ed75656f)), closes [#394](https://www.github.com/googleapis/java-bigquery/issues/394)
* **samples:** Fix flaky test ([#397](https://www.github.com/googleapis/java-bigquery/issues/397)) ([64847d1](https://www.github.com/googleapis/java-bigquery/commit/64847d1e5137e811e7f462fc058908fa9fcc55fb))
* **samples:** update revierwers for samples module changes ([#401](https://www.github.com/googleapis/java-bigquery/issues/401)) ([69b9d84](https://www.github.com/googleapis/java-bigquery/commit/69b9d8417d5b910286aaa855f4a83fc151a81cec))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants