Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add samples #44

Merged
merged 6 commits into from Dec 18, 2019
Merged

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Dec 17, 2019

Fixes b/146347707, b/146452106

@googlebot googlebot added the cla: yes label Dec 17, 2019
@codecov
Copy link

@codecov codecov bot commented Dec 17, 2019

Codecov Report

Merging #44 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #44      +/-   ##
============================================
- Coverage     77.36%   77.32%   -0.04%     
- Complexity     1107     1108       +1     
============================================
  Files            73       73              
  Lines          5911     5915       +4     
  Branches        645      645              
============================================
+ Hits           4573     4574       +1     
- Misses         1012     1014       +2     
- Partials        326      327       +1
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/google/cloud/bigquery/Field.java 82.79% <0%> (-2.6%) 25% <0%> (+1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f9465...116f215. Read the comment docs.

@stephaniewang526 stephaniewang526 requested a review from kurtisvg Dec 18, 2019
@stephaniewang526 stephaniewang526 requested a review from pmakani Dec 18, 2019
@stephaniewang526 stephaniewang526 merged commit d3e5e12 into googleapis:master Dec 18, 2019
12 of 13 checks passed
@stephaniewang526 stephaniewang526 deleted the feat-samples branch Dec 18, 2019

public static void runExtractTableToJSON() {
// TODO(developer): Replace these variables before running the sample.
Table table = null;
Copy link
Contributor

@kurtisvg kurtisvg Dec 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this null? We should be showing the user how to initialize this value.

Copy link
Member Author

@stephaniewang526 stephaniewang526 Dec 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My initial thought is user should be able to pass in a Table object of their choice to extract into GCS as CSV - but I think what you said makes sense too. We can offer an example of what this Table object could be.

@stephaniewang526 stephaniewang526 restored the feat-samples branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants